Skip to content

Replace assert with ASSERT #17408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Replace assert with ASSERT #17408

wants to merge 1 commit into from

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Nov 7, 2019

ASSERT does the same as the current assert in Bitcoin Core, with the only difference of printing a bug report to stderr. Also, it comes with documentation when to use it.

@maflcko
Copy link
Member Author

maflcko commented Nov 7, 2019

Not sure if this is worth it, so mostly for brainstorming.

@maflcko
Copy link
Member Author

maflcko commented Nov 7, 2019

Closing for now. I will pick this up some time later.

@maflcko maflcko closed this Nov 7, 2019
@maflcko maflcko deleted the 1911-assertASSERT branch November 7, 2019 22:51
@maflcko maflcko mentioned this pull request Jun 15, 2020
Merged
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Brainstorming Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maflcko