Do not accept orphan blocks in -loadblock mode #1695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this cleanup orphan blocks stored in our block-files when re-importing them as new block-files? |
|
ACK |
|
@Diapolo Normally, block files do not contain orphan blocks (by which i mean blocks that have no known parent), they do have chains of stale chains that got reorganised away (which is what I assume you're talking about). This only prevents real orphan blocks from being imported. |
|
ACK |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/5c88e3c108f8bbe0edbcd88b3f48e3eaf611cd7c for binaries and test log. |
sipa
added a commit
that referenced
this pull request
Aug 22, 2012
Do not accept orphan blocks in -loadblock mode
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
* fix edge case for IS (skip inputs that are too large) * fix
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
owlhooter
pushed a commit
to owlhooter/mazacoin-new
that referenced
this pull request
Oct 10, 2018
…et (bitcoin#1819) bitcoin#1695 introduced a fix for a instant send related edge case. Somehow the parameters got mixed up and fUseInstantSend was passed as "iterations".
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In -loadblock mode, ProcessBlock() is called without node to retrieve parents from, if needed. In this case, prefer to not store orphans as all, as they would just linger in RAM.