Skip to content

Conversation

gmaxwell
Copy link
Contributor

@gmaxwell gmaxwell commented Aug 1, 2012

No description provided.

@gmaxwell
Copy link
Contributor Author

gmaxwell commented Aug 1, 2012

This is currently the unmodified listaddressgroupings RPC from the coincontrol patch. It's been tested for basic functionality.

I observe that it misbehaves a little when you have transaction with some inputs which aren't yours e.g.:
[
"mgrxrEzVVvf5TDt4PVc3EpiJrJGt52RXfZ",
100.00000000,
""
]

(the empty quote)

But I expect thats easily fixed. The bigger question is do we want to change this to make it work better in the context of raw transactions? Listunspent gives txouts without addresses, so going from this list to a raw transaction doesn't quite work. Ideas?

@jgarzik
Copy link
Contributor

jgarzik commented Aug 1, 2012

ACK

@gmaxwell
Copy link
Contributor Author

gmaxwell commented Aug 1, 2012

Perhaps when it can't decode an address it should return the txout? And the mismatch with listunspent should be fixed by allowing listunspent to take a list of addresses to filter with?

Signed-off-by: Gregory Maxwell <greg@xiph.org>
@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/396878ff5fd76905156d442106ef1ae973748d00 for binaries and test log.

@gmaxwell
Copy link
Contributor Author

duplicated in another pull request (#1672) now.

@gmaxwell gmaxwell closed this Aug 20, 2012
suprnurd pushed a commit to chaincoin-legacy/chaincoin that referenced this pull request Dec 5, 2017
…tcoin#1642)

The getblocktemplate RPC call fails if used before node is fully synced.
This change fixes extended functional tests that were failing
because of that.

Signed-off-by: Oleg Girko <ol@infoserver.lv>
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants