Add new P2P command and response: "getcmds", "cmdlist" #1471
Conversation
This lists the capabilities of the remote node, in the form of a vector<string> list of commands advertised by remote node.
|
What's up with adding all the P2P commands lately? Shouldn't this be discussed in a BIP? Personally I still think it's better to have a clear standardized "protocol version", that implies what capabilities are supported, instead of a capability-based system that explicitly lists them. Capability-based systems tend to become horrendously complex, as you have to take into account all possible combinations of possible interactions, and constantly check for support of specific features instead of just comparing a version number. |
|
@laanwj ACK |
|
No, you don't discuss things in a BIP. You first implement the code, then discuss on the mailing list and forums. |
|
Yes I meant describe in a BIP. |
|
@jgarzik Well, FWIW, @gavinandresen is always saying to discuss on the mailing list before making pull requests... But this whole thread of discussion is IMO off-topic for here... |
|
Closing, not sufficient consensus or interest, based on mailing list discussion |
de45ddc [GUI] MnWizard: validate IP (random-zebra) 0e3c18f [GUI][Bug] MnWizard: Fix validators for masternode alias and port (random-zebra) Pull request description: First commit fixes the masternode alias: right now only letters and digits are allowed, but special characters (except spaces and hash marks) should be allowed too. It also replaces deprecated `QRegExp` with `QRegularExpression` (as per bitcoin#1124) and fixes the port number to the default. Closes bitcoin#1471 Second commit introduces validation for masternode IP addresses: they should be valid IPv4, IPv6 or .onion addresses and, if not on regtest, they should be reachable and routable. A unit test for the new `validateMasternodeIP` function is added to netbase_tests. Also removes the validation for the port, since it's fixed to network-default. ACKs for top commit: Fuzzbawls: ACK de45ddc furszy: ACK de45ddc Tree-SHA512: f9479483e4d41b80b83b4ca5cd57912dc027e020b92034090e9e1d01a1486696d70ce2fc3cf7253c18cdfcda273f5e203929a3e240f9d3d660b110c3bd009ef8
This lists the capabilities of the remote node, in the form of a
vector list of commands advertised by remote node.