Skip to content

Conversation

ken2812221
Copy link
Contributor

SECURE style seem to be unused. According to the comment it do the same thing as -nodebuglogfile

@fanquake fanquake added the GUI label Nov 5, 2018
@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 5, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

Coverage

Coverage Change (pull 14655) Reference (master)
Lines +0.0022 % 87.0960 %
Functions -0.0612 % 84.3822 %
Branches +0.0019 % 51.5722 %

Updated at: 2018-11-05T21:07:19.026465.

@fanquake
Copy link
Member

fanquake commented Nov 5, 2018

tACK 1687fc2

The single usage of the SECURE style was added in #5095, but was removed in #6388.

@promag
Copy link
Contributor

promag commented Nov 5, 2018

utACK 1687fc2.

@laanwj
Copy link
Member

laanwj commented Nov 5, 2018

should we be using this anywhere?

@ken2812221
Copy link
Contributor Author

should we be using this anywhere?

The code is unused for a really long time. From the comment that I know that this is to not print debug log to file. The function can be replaced by gArgs.ForceSetArg IMO.

@maflcko
Copy link
Member

maflcko commented Nov 5, 2018

It is not meant as a global flag to print to the debug log, but rather a per-message flag to disable the printing for this message.

@laanwj
Copy link
Member

laanwj commented Nov 6, 2018

yes, I think it's fair enough to respond "no, we have no use for this", but I have the feeling that you misunderstand what it does.
@MarcoFalke explains it well.

@jonasschnelli
Copy link
Contributor

Somehow this seems to be useful per message flag. I'm don't mind if there is code options we don't use at the moment for future leverage of using it at the right place.
Agree with @laanwj about the should.

@ken2812221
Copy link
Contributor Author

Closing. So we can keep this flag for the future sensitive messages that shouldn't be stored in the debug log. It can only be displayed on screen.

@ken2812221 ken2812221 closed this Nov 7, 2018
@ken2812221 ken2812221 deleted the qt-unused-secure branch November 7, 2018 03:00
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants