wallet: Avoid calling uiInterface.LoadWallet(...) with cs_wallet held #14560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain why this is needed? |
|
@MarcoFalke before #11634 the lock wasn't held when calling |
|
Yeah, I don't see the change in behaviour. Is there any? |
|
Ok, updated my comment. |
|
Ah ok. Slightly tend to NACK due to our refactoring guidelines. |
|
@MarcoFalke Makes sense! Closing :-) |
|
I don't get it why this is refactoring, this should just revert something that was changed for no good reason. Anyway it was just a comment. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #11634.
Context: #11634 (comment)