GUI: re-work current options dialog to a tabbed layout and use an UI-file #1433
Conversation
|
Haven't had time to test it yet, but yeah this is better |
|
Updated and added:
|
|
Updated to reflect changes made in #1434 and use a well-formated commit message ;). |
|
I've tested it, works great. The default dialog size is a bit small, I'd recommend making it a bit larger. Apart from that, ACK |
|
I'm going to add a restart warning for enabling / disabling SOCKS proxy and will re-size the dialog a little. If this is in, it would be really nice to get this into 0.7, do you think that's possible @laanwj? |
|
Yes, that's possible. Gotta love UI-only changes. |
|
Last update: make dialog a little bigger in size / add warning for enabling / disabling SOCKS proxy |
| QPushButton *apply_button; | ||
|
|
||
| QList<OptionsPage*> pages; | ||
| bool fRestartWarningDisplayed_Lang; |
There was a problem hiding this comment.
Where is bool fRestartWarningDisplayed_Proxy?
There was a problem hiding this comment.
It was on a vacation ... I missed the header-update, sorry :-/. Fixed!
- extend network options with a SOCKS version selection - changing "Unit to show amounts in:" now also updates the unit used in the transaction fee box - string updates - link Apply button and OK button when enabling or disabling them - use LookupNumeric() from netbase to verify proxy address (via an EventFilter) - change proxy address field to QValidatedLineEdit and add visual feedback - add a status label used for displaying a message for invalid proxy addresses - allow usage of IPv6 address as proxy address - added warning message when enabling / disabling SOCKS proxy
|
ACK We should find a more general way of doing the restart warnings later (for example, using a map of QWidget* instead of booleans, so that one function can be used), but that isn't needed for this commit. BTW: we probably need a translations update after this? |
GUI: re-work current options dialog to a tabbed layout and use an UI-file
|
We need for sure a translation update, yes :). I suggest you do a bitcoinstrings.cpp update and I will fetch current translations from Transifex, create a pull and tomorrow I'll generate a new english master file. |
GUI: re-work current options dialog to a tabbed layout and use an UI-file
Fix ctor.py from failing
…tion locals 58b39ca [Scripts] Add override flag to fetch all translations (Fuzzbawls) a747678 [Scripts] Add Transifex CLI configuration slug (Fuzzbawls) db7e68a [Scripts] Only fetch translations for high-completion locals (Fuzzbawls) Pull request description: This restricts the fetching of translations from Transifex during the translation process to only fetch the translations that meet a defined minimum completion threshold percentage. In order to allow testers/self-compilers to see partial translations in-wallet, a runtime override flag has been added to the `update-translations.py` script; `--ignore_completion` Also, finally add the public configuration file for the `tx` CLI tool Closes bitcoin#1432 ACKs for top commit: random-zebra: ACK 58b39ca furszy: ACK 58b39ca Tree-SHA512: 27becc586059deb9d1e97e6483e8c55da9b29b2d29a72e3b73093c33e41bb250c9c7f8c11a5390c0385e13b3b3869ae21c8d71729b6ddf1d035521689d62dff0
This needs a review and compilation test from a dev, but I want to ensure there is time to discuss it early!
benefits:
The changes to optionsdialog.cpp/.h may look weird, but I designed it from scratch and only replace the current files, to keep the naming.