The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #14605 (Return of the Banman by dongcarl)
• #14224 (Document intentional and unintentional unsigned integer overflows (wraparounds) using annotations by practicalswift)
• #13864 (validation: Document where we are intentionally ignoring bool return values from validation related functions by practicalswift)
• #13815 (util: Add [[nodiscard]] to all {Decode,Parse}... functions returning bool by practicalswift)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Concept ACK maybe_unused is a C++17 introduction, I assume it's ok to use it though based on preprocessor activation.

@Empact Yes, it is worth noting that both clang++ and g++ support [[maybe_unused]] also under -std=c++11. Luckily no need for wait for C++17 :-)

BlockNotifyGenesisWait uses unnamed args to mark them as unreferenced.
Should we name there or apply that here?

@ken2812221 Updated to address feedback. Please re-review :-)

@arvidn Good points. Now updated. Also added a developer note. Please re-review :-)