@ashleyholman Thanks for picking this up. You're on the right track. For polling node statistics it makes sense to just update them at regular intervals. Indeed, to probe every second or so.

Like the other GUI polling functions we'd want to make this poll optional. Start the timer handler with a TRY_LOCK on cs_vNodes, and if you don't get the lock, skip this update this time. This avoids hanging the GUI thread on the lock. You can release the lock immediately after copying the data.

You could use the NotifyNumConnectionsChanged() signal as @federicobond mentions to be notified when new nodes could be added or nodes disconnected instantly. This would introduce a possible DoS risk because a node could connect/disconnect 100s of times per second, updating the table every time.

(this is always a compromise; at some point with continuous or fast-changing statistics polling is preferable to change notifications; a thermometer that sends a message every time the temperature changes would clog up all bandwidth)

Just some quick notes in terms of where the model code would go (is a new model class needed?)

Maybe a PeerTableModel that is part of the ClientModel. It could live in its own cpp/h files.

what GUI widgets to use (QTableView?)

What GUI to use is up to you :) In my mind there would be a table that shows the most important statistics for every node, and maybe a details window/pane that can show the nitty gritty details that don't fit into the table.

Indeed, using QTableView would be consistent with what is used for the transactions list, address lists, etc. It's also easiest to get a grid of information that way.

@rebroad That would be useful, but I'd prefer if that is handled in a separate pull that adds that information to the RPC first.
When first adding this to the GUI let's show what is in getpeerinfo already, so that the change is manageable.

Show list of peers in debug window #4133

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions