Skip to content

cmake: Replace file(GLOB ...) command with an explicit list of *.ts files #32653

New issue
New issue
Closed
#33115
bitcoin-core/bitcoin-maintainer-tools
#185
Closed
cmake: Replace file(GLOB ...) command with an explicit list of *.ts files#32653
#33115
bitcoin-core/bitcoin-maintainer-tools
#185
Labels
Build systemGUI
@hebasto

Description

@hebasto
hebasto
opened on May 31, 2025

From CMake docs:

We do not recommend using GLOB to collect a list of source files from your source tree. If no CMakeLists.txt file changes when a source is added or removed then the generated build system cannot know when to ask CMake to regenerate.

So the following case has to be reworked:

bitcoin/src/qt/CMakeLists.txt

Lines 57 to 60 in 4b1d48a

# TODO: The file(GLOB ...) command should be replaced with an explicit
# file list. Such a change must be synced with the corresponding change
# to https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/update-translations.py
file(GLOB ts_files RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} locale/*.ts)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Build systemGUI

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions