-
Notifications
You must be signed in to change notification settings - Fork 37.7k
Closed
Labels
Milestone
Description
The test-security-check
and test-symbol-check
scripts still reference Autoconf and it's behaviour:
def env_flags() -> list[str]:
# This should behave the same as AC_TRY_LINK, so arrange well-known flags
# in the same order as autoconf would.
#
# See the definitions for ac_link in autoconf's lib/autoconf/c.m4 file for
# reference.
The also expect CPPFLAGS
to be passed into them, but this isn't happening from CMake:
bitcoin/cmake/module/Maintenance.cmake
Line 40 in d7f56cc
COMMAND ${CMAKE_COMMAND} -E env CXX=${cxx_compiler_command} CXXFLAGS=${CMAKE_CXX_FLAGS} LDFLAGS=${CMAKE_EXE_LINKER_FLAGS} ${PYTHON_COMMAND} ${PROJECT_SOURCE_DIR}/contrib/devtools/test-security-check.py TestSecurityChecks.test_${exe_format} |