Skip to content

Update nChainTx to 64bit type #29258

New issue
New issue
Closed
#29656
Closed
Update nChainTx to 64bit type#29258
#29656
Labels
Validation
@ajtowns

Description

@ajtowns
ajtowns
opened on Jan 17, 2024

bitcoin/src/chain.h

Lines 178 to 186 in 8106b26

//! (memory only) Number of transactions in the chain up to and including this block.
//! This value will be non-zero only if and only if transactions for this block and all its parents are available.
//! Change to 64-bit type before 2024 (assuming worst case of 60 byte transactions).
//!
//! Note: this value is faked during use of a UTXO snapshot because we don't
//! have the underlying block data available during snapshot load.
//! @sa AssumeutxoData
//! @sa ActivateSnapshot
unsigned int nChainTx{0};

Hey, it's 2024! nChainTx seems to currently be 953368191 (height 826100), which is hex 38d3 3e7f, so we're only 22% of the way to an overflow, and would still need another 200k blocks (~ four years) full of 60 byte transactions to get there.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Validation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions