Skip to content

Performance decrease after tapscript miniscript #29098

@Sjors

Description

@Sjors

Is there an existing issue for this?

  • I have searched the existing issues

Current behaviour

@eriknylund noticed while testing large multisigs that after 4f473ea sendtoaddress causes a timeout for much smaller (though still rather large) multisigs than before.

#28212 (comment)

Expected behaviour

Not sure, perhaps the performance decrease is justified. Ideally it would not slow down.

Since these descriptors don't involve any miniscript-specific operations, perhaps it's possible to return earlier in whatever parsing / signing algorithm is involved here.

Steps to reproduce

Run the large multisig test in the above mentioned PR before and after the commit.

Relevant log output

No response

How did you obtain Bitcoin Core

Compiled from source

What version of Bitcoin Core are you using?

master@4f473ea515bc77b9138323dab8a741c063d32e8f

Operating system and version

macOS and CI

Machine specifications

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions