Guix builds are affected by external environment #29754
Description
Here is a demo branch.
It is based on the master branch @ c8e3978 with the only diff applied on the top of it:
--- a/depends/hosts/darwin.mk
+++ b/depends/hosts/darwin.mk
@@ -95,7 +95,7 @@ darwin_CXX=env -u C_INCLUDE_PATH -u CPLUS_INCLUDE_PATH \
darwin_CFLAGS=-pipe -std=$(C_STANDARD) -mmacosx-version-min=$(OSX_MIN_VERSION)
darwin_CXXFLAGS=-pipe -std=$(CXX_STANDARD) -mmacosx-version-min=$(OSX_MIN_VERSION)
-darwin_LDFLAGS=-Wl,-platform_version,macos,$(OSX_MIN_VERSION),$(OSX_SDK_VERSION)
+# darwin_LDFLAGS=-Wl,-platform_version,macos,$(OSX_MIN_VERSION),$(OSX_SDK_VERSION)
ifneq ($(build_os),darwin)
darwin_CFLAGS += -mlinker-version=$(LD64_VERSION)One might expect that not passing the -Wl,-platform_version,macos flag to a linker will cause the check_MACHO_sdk in the symbol-check.py to fail.
That's true on Ubuntu 22.04 LTS:
...
Running symbol and dynamic library checks...
bitcoind: failed SDK
bitcoin-cli: failed SDK
bitcoin-tx: failed SDK
bitcoin-wallet: failed SDK
bitcoin-util: failed SDK
test/test_bitcoin: failed SDK
qt/bitcoin-qt: failed SDK
make: *** [Makefile:23004: check-symbols] Error 1
make: Leaving directory '/distsrc-base/distsrc-d9aae66b3efa-x86_64-apple-darwin/src'
But all tests pass on Ubuntu 23.10:
x86_64
ce93a8c05df4d31fa1e33862ba63318a7350fb175a5f25eae771e24447fc3cda guix-build-d9aae66b3efa/output/dist-archive/bitcoin-d9aae66b3efa.tar.gz
d7d821344fde3e5cedf937846f57cfd298e1b5ce8956d1e5c04e59bde2b23c8d guix-build-d9aae66b3efa/output/x86_64-apple-darwin/SHA256SUMS.part
1a9288baaa43a2ad0bfd339d41d0616d879bdd82323e1b17cddb32453f2b3733 guix-build-d9aae66b3efa/output/x86_64-apple-darwin/bitcoin-d9aae66b3efa-x86_64-apple-darwin-unsigned.tar.gz
5b49447f9222161d48b6d435e5ff064132727e8f90f90a239738a29a3c0b9111 guix-build-d9aae66b3efa/output/x86_64-apple-darwin/bitcoin-d9aae66b3efa-x86_64-apple-darwin-unsigned.zip
af6c0a3db2cc0e046ff3c4c4f4fb3fce705e8b382aadb3b6cfbb153da55e60d3 guix-build-d9aae66b3efa/output/x86_64-apple-darwin/bitcoin-d9aae66b3efa-x86_64-apple-darwin.tar.gz