Skip to content

Remove m_is_test_chain, use ChainType directly #28376

@maflcko

Description

@maflcko

Motivation

m_is_test_chain is a bool, which has the meaning m_chain_type!=MAIN. This is just bloats the code with test-only code, so it should be removed and be replaced by the equivalent meaning. See the output of git grep m_is_test_chain and the suggestion #28316 (comment)

Possible solution

Useful Skills

  • Compiling Bitcoin Core from source
  • Running the C++ unit tests and the Python functional tests

Guidance for new contributors

Want to work on this issue?

For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions