Skip to content

compiler warning on building src/test/test_bitcoin-validation_chainstate_tests.o #23101

@katesalazar

Description

@katesalazar

Is your feature request related to a problem? Please describe.

Warning on building using g++ 8.3.

 1 In file included from ./txdb.h:11,
 2                  from ./validation.h:26,
 3                  from ./test/util/chainstate.h:13,
 4                  from test/validation_chainstate_tests.cpp:11:
 5 ./chain.h: In member function ‘void validation_chainstate_tests::chainstate_update_tip::test_method()’:
 6 ./chain.h:422:27: warning: ‘background_cs’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 7          return vChain.size() > 0 ? vChain[vChain.size() - 1] : nullptr;
 8                 ~~~~~~~~~~~^~
 9 test/validation_chainstate_tests.cpp:109:18: note: ‘background_cs’ was declared here
10      CChainState* background_cs;
11                   ^~~~~~~~~~~~~
12

Describe the solution you'd like

Able to build without warnings.

Describe alternatives you've considered

N/A.

Additional context

cd src/ && make test/test_bitcoin-validation_chainstate_tests.o

Bisecting this warning, I ended up in revision 673a5bd
by @jamesob.

Thank you very much and please excuse the noise.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions