Skip to content

make install creates files/folders with bad permissions if custom umask is used #22595

@xanoni

Description

@xanoni

The make install script, which most users would run via sudo to install into /usr/local, will use the current umask of the root user when creating certain files and directories. If one uses a restrictive umask by default (e.g. umask 077), this means that only the root user will be able to use the full Bitcoin package.

Expected behavior

The install script creates all directories and files, including man pages, etc., with permissions 644 / 755.

Actual behavior

Certain folders are created using the default umask, e.g.:

  • /usr/local/share/man/man1/
  • /usr/local/lib/pkgconfig/
  • [...]

This means that only root can access files in these folders and other users won't be able to read the man pages (for example).

To reproduce

$ ./autogen.sh
$ make
$ sudo -iu root
% umask 077
% make install

System information

OS: Linux
bitcoind version: HEAD

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions