Skip to content

Show the "<n> of the last 100 blocks have unexpected version" warning only when running -debug=validation? #19603

@practicalswift

Description

@practicalswift

Google search results suggest that our users are more confused than helped by the <n> of the last 100 blocks have unexpected version warning we're printing.

As developers we know the unfortunate reason behind this warning and how "unexpected" should be interpreted in this context, and thus why it is safe to disregard this warning. However, I don't think it reasonable to expect our users to know the historical context here.

In order to not desensitize our users to potentially critical "real" warnings, would it make sense to move this message to the -debug=validation log category?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions