You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we use assert in RPC code to document logic and code assumptions. However, it seems a bit extreme to abort all of Bitcoin Core on an assert failure in one of the RPC threads. I suggest to replace all checks with a macro THROW_LOGIC_ERROR_IF_ASSERT_FAILS(condition) that does what it says. That logic error will then be returned to the rpc caller and will include instructions to report the error to our issue tracker.
Any objections or naming suggestions for that macro?