Skip to content

listrecievedbyaddress with include_empty not filtering out "send" side of address book #16159

@sidhujag

Description

@sidhujag

I noticed if you call listreceivedbyaddress with true for incude_empty it was skipping the cross-reference against mapTally. The skip causes the entire address book (including "send" purpose) to be included in the results erroneously. There should be a "if purpose not 'send' then include results".

Code would be inserted here:

https://github.com/bitcoin/bitcoin/blob/master/src/wallet/rpcwallet.cpp#L1122

something like:

        if(item_it->second.purpose == "send")
            continue;

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions