Skip to content

Use icons from the system icon theme where possible #1222

@ssokolow

Description

@ssokolow

Currently, the icons in the BitCoin wallet stick out like sore thumbs on the vast majority of Linux desktops. (Probably looking the least out of place on KDE-based desktops, given the design aesthetic.)

The QIcon initializers in BitcoinGUI::createActions() in src/qt/bitcoingui.cpp should be changed to use QIcon::fromTheme instead.

Also, the icons in :/icons/ should be renamed to match the XDG icon-naming spec so the fallback behaviour is preserved without needing to provide the optional second parameter to fromTheme.

For example:

  • QIcon(":/icons/filesave") should become QIcon::fromTheme("document-save")
  • QIcon(":/icons/quit") should become QIcon::fromTheme("application-exit")
  • QIcon(":/icons/address-book") should become QIcon::fromTheme("x-office-address-book")
  • document-properties would be a good standard replacement for :/icons/options
  • You can get away with using go-next and go-down to replace :/icons/send and :/icons/receiving_addresses

Ideally, you'll want to install any icons not covered by the icon-naming spec in the appropriate size and category subfolders of the fallback theme at $PREFIX/share/icons/hicolor/ where it's easy for theme authors to look up the names to override.

Here's all the relevant documentation:

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions