BIP 322 utility functions #3823
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @apoelstra @kallewoof if you guys could give some review would appriecate it |
|
Did a cursory look-over and it looks reasonable. If you could make test vectors I'll see about getting Bitcoin Core RPC variants in place. |
Made some test vectors, LMK what you think |
|
todo: test against bitcoin/bitcoin#24058 |
|
WIP test vectors in bitcoin/bips#1279 |
Mertz22
approved these changes
Apr 12, 2022
39 tasks
Braya13
reviewed
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't find any test vectors or alternate implementations so hopefully can get review from the BIP authors
https://github.com/bitcoin/bips/blob/master/bip-0322.mediawiki