Add signet pools #82
Merged
Add signet pools #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I've updated your branch with a few commits making sure the signet pool data is also checked with |
|
Changes look good to me, clicked the button |
78bb287 to
94b41f5
Compare
achow101
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Sep 4, 2024
fb6d51e signet/miner: Use argparse exclusive groups (Anthony Towns) 338a266 signet/miner: add support for a poolnum/poolid tag in mined blocks (Anthony Towns) 409ab7d signet/miner: add Generate.mine function (Anthony Towns) 7b31332 signet/miner: add Generate.gbt function (Anthony Towns) 85c5c0b signet/miner: add Generate.next_block_time function (Anthony Towns) 5540e6c signet/miner: move next_block_* functions into new Generator class (Anthony Towns) 35f4631 signet/miner: rename do_decode_psbt to decode_psbt (Anthony Towns) aac040b signet/miner: drop create_coinbase function (Anthony Towns) 16951f5 signet/miner: drop do_createpsbt function (Anthony Towns) 3aed0a4 signet/miner: drop get_reward_address function (Anthony Towns) Pull request description: Refactors the code a bunch, and adds `--poolnum` / `--poolid` options so that signers can tag their coinbases in a way that explorers can recognise (see also bitcoin-data/mining-pools#82 and mempool/mempool#2903). The refactoring in particular helps enable the "try using inquisition's getblocktemplate, and if that doesn't work fall back to core's getblocktemplate" logic, as described/implemented in bitcoin-inquisition#7 ACKs for top commit: achow101: ACK fb6d51e danielabrozzoni: Code review ACK fb6d51e Tree-SHA512: d84095c4045ab196685b847e04ce2cdaedf387bc2527430ede918318dc5b70bf3d87b754264016f895f506fac70d4fdea5ef3cd8c3c375fd586afeae01e045e5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds json files for the different signet miners, and updates generate-json-pool-list.py to allow specifying both the output file name and also the entities directory.