Skip to content

Conversation

theStack
Copy link
Contributor

@theStack theStack commented Sep 7, 2025

The CMake library output location was changed from "src/" to "lib/" in PR #1553, supporting the old location (presumably done to avoid having users to reconfigure existing CMake builds for a temporary transition window) shouldn't be necessary anymore.

…(src/libsecp256k1.so)

The CMake library output location was changed from "src/" to "lib/"
in PR bitcoin-core#1553, supporting the old location shouldn't be necessary anymore.
Copy link
Contributor

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 7ebaa13

@real-or-random real-or-random merged commit 36e7695 into bitcoin-core:master Sep 9, 2025
119 checks passed
@theStack theStack deleted the check-abi-remove_temporary_cmake_out_detection branch September 9, 2025 08:51
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge ACK 7ebaa13. Tested on Ubuntu 25.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants