travis: Explicitly set --with-valgrind #821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-jr
reviewed
Sep 19, 2020
995b240 to
2470053
Compare
Also set --with-valgrind=no once
|
Split into two commits. |
2470053 to
4eecb4d
Compare
Also remove CPPFLAGS=-DVALGRIND because that's redundant when configured with --with-valgrind.
|
ACK 4eecb4d diff and travis output look good |
|
utACK 4eecb4d |
|
ACK 4eecb4d |
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 29, 2020
Summary: ``` Also remove CPPFLAGS=-DVALGRIND because that's redundant with when configured with --enable-valgrind. ``` Backport of secp256k1 [[bitcoin-core/secp256k1#821 | PR821]]. Test Plan: Run the Travis build. https://travis-ci.org/github/Fabcien/secp256k1/builds/731225830 Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7633
deadalnix
pushed a commit
to Bitcoin-ABC/secp256k1
that referenced
this pull request
Sep 30, 2020
Summary: ``` Also remove CPPFLAGS=-DVALGRIND because that's redundant with when configured with --enable-valgrind. ``` Backport of secp256k1 [[bitcoin-core/secp256k1#821 | PR821]]. Test Plan: Run the Travis build. https://travis-ci.org/github/Fabcien/secp256k1/builds/731225830 Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7633
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove CPPFLAGS=-DVALGRIND because that's redundant with when
configured with --enable-valgrind.