Skip to content

Undef HAVE___INT128 in basic-config.h to fix gen_context compilation #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2020
Merged

Undef HAVE___INT128 in basic-config.h to fix gen_context compilation #769

merged 1 commit into from
Jul 21, 2020
+1 −0

Conversation

real-or-random
Copy link
Contributor

Fixes #768.

@sipa
Copy link
Contributor

sipa commented Jul 21, 2020

utACK

jonasnick
jonasnick approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 22e578b

@jonasnick jonasnick merged commit 2309c7d into bitcoin-core:master Jul 21, 2020
@elichai elichai mentioned this pull request Jul 23, 2020
Closed
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Sep 27, 2020
@real-or-random @deadalnix
Undef HAVE___INT128 in basic-config.h to fix gen_context compilation
4846541 
Summary:
Fixes #768.

This is a backport of libsecp256k1 [[bitcoin-core/secp256k1#769 | PR769]]

Test Plan:
  ninja check-secp256k1

That doesn't really cover the change, but I really do nto have the setup to repro. At least it doesn't break anything.

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D7593
deadalnix pushed a commit to Bitcoin-ABC/secp256k1 that referenced this pull request Sep 28, 2020
@real-or-random @deadalnix
Undef HAVE___INT128 in basic-config.h to fix gen_context compilation
b81e160 
Summary:
Fixes #768.

This is a backport of libsecp256k1 [[bitcoin-core/secp256k1#769 | PR769]]

Test Plan:
  ninja check-secp256k1

That doesn't really cover the change, but I really do nto have the setup to repro. At least it doesn't break anything.

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D7593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasnick jonasnick jonasnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue compiling on OpenBSD 6.7
3 participants
@real-or-random @sipa @jonasnick