Skip to content

Conversation

practicalswift
Copy link
Contributor

Make sure we're not passing an uninitialized array to memcmp(...).

@gmaxwell
Copy link
Contributor

I think this change would reduce the sensitivity of valgrind. By initializing it ourselves we'll suppress errors where the underlying code, which should have initialized it at least up to the length we're using failed to do so.

@gmaxwell
Copy link
Contributor

I still don't see a reason to do this and there hasn't been recent activity. I believe I understand the motivation, I think the disadvantage of masking errors that valgring/mem-santizer would find makes it not worth it. The valgrind component of the concern could be avoided by using valgrind macros to mark the array uninitilized but I'm aware of no comparable change for the sanitizers.

@practicalswift
Copy link
Contributor Author

Fix in #627.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants