Skip to content

Preconditions of fe_equal_var are weaker than documented #946

@real-or-random

Description

@real-or-random

From IRC:

<roconnor> The documentation for secp256k1_fe_equal_var suggest both inputs have to have magnitude 1; however only the first input needs to have magnitude 1.
<roconnor> thus this call to fe_normalize_weak could be eliminated.
<roconnor> But it is so very not critical, I'm not sure it is even worth PRing.
<real_or_random> roconnor: same thing happens in secp256k1_gej_eq_x_var which is used in ECDSA verification. but ok, the speedup is still negligible
<real_or_random> but I believe it's worth a PR (or an issue) because it would improve the internal docs

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions