These functions can actually return 0, but this requires a violation of the API:

secp256k1/src/modules/extrakeys/main_impl.h

Lines 44 to 54 in b40e2d3

    
           int secp256k1_xonly_pubkey_serialize(const secp256k1_context* ctx, unsigned char *output32, const secp256k1_xonly_pubkey *pubkey) { 
        
               secp256k1_ge pk; 
        
               VERIFY_CHECK(ctx != NULL); 
        
               ARG_CHECK(output32 != NULL); 
        
               memset(output32, 0, 32); 
        
               ARG_CHECK(pubkey != NULL); 
        
               if (!secp256k1_xonly_pubkey_load(ctx, &pk, pubkey)) { 
        
                   return 0; 
        
               }

Wouldn't it make more sense to call the illegal callback in that case?

	int secp256k1_xonly_pubkey_serialize(const secp256k1_context* ctx, unsigned char output32, const secp256k1_xonly_pubkey pubkey) {
	secp256k1_ge pk;

	VERIFY_CHECK(ctx != NULL);
	ARG_CHECK(output32 != NULL);
	memset(output32, 0, 32);
	ARG_CHECK(pubkey != NULL);

	if (!secp256k1_xonly_pubkey_load(ctx, &pk, pubkey)) {
	return 0;
	}

Remove SECP256K1_WARN_UNUSED_RESULT from secp256k1_keypair_* functions #1379

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Remove `SECP256K1_WARN_UNUSED_RESULT` from `secp256k1_keypair_*` functions #1379