Skip to content

Conversation

fanquake
Copy link
Member

No description provided.

@maflcko
Copy link
Contributor

maflcko commented May 24, 2023

If it passed locally, it should be fine

@fanquake
Copy link
Member Author

Can/should we bump the timeout?

@fanquake fanquake force-pushed the fix_msan_fuzz branch 2 times, most recently from 326a4b8 to 659d746 Compare May 24, 2023 12:42
@fanquake
Copy link
Member Author

Droped the branch change, can be merged after bitcoin/bitcoin#27737.

@fanquake fanquake changed the title [NO MERGE] test fix for native_fuzz_msan job ci: update native_fuzz_msan job for upstream changes May 24, 2023
fanquake added a commit to bitcoin-core/gui that referenced this pull request Jun 2, 2023
…n jobs

5763b23 ci: return to using Ubuntu 22.04 in MSAN jobs (fanquake)
d3cbcbf ci: compile clang and compiler-rt in MSAN jobs (fanquake)
796bd1d ci: use LLVM 16.0.4 in MSAN jobs (fanquake)
883bc9f ci: remove extra CC & CXX from MSAN jobs (fanquake)
2d4f4b8 ci: standardize custom libc++ usage in MSAN jobs (fanquake)

Pull request description:

  This reworks the MSAN CIs, to first compile Clang and compiler-rt (using GCC 12), and then, compile an MSAN instrumented libc++ using the just-built Clang 16. This fixes the `native_fuzz_with_msan` job, working around https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1005341, by not using the Debian provided Clang/LLVM.

  Also included are changes to streamline how we use our "custom libc++", according to upstream: https://releases.llvm.org/16.0.0/projects/libcxx/docs/UsingLibcxx.html#using-a-custom-built-libc, as well as other minor cleanups in the CI configs.

  An example job is currently running in the qa-assets repo: bitcoin-core/qa-assets#129 (https://cirrus-ci.com/task/4632561431871488).

ACKs for top commit:
  dergoegge:
    utACK 5763b23

Tree-SHA512: 4f2a6e0b796bb1830b8346dd1e55eaa86a79037b8b4f16a336c1e29f4fc460acca2ecba076635459370bcbb4009333cb79d27ef1521c1fb5db7599cd5bdf558c
Copy link
Member

@dergoegge dergoegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 0822d8c

@fanquake fanquake merged commit 2dc7578 into bitcoin-core:main Jun 2, 2023
@fanquake fanquake deleted the fix_msan_fuzz branch June 2, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants