descriptor_parse: extend coverage with Miniscript Descriptors inputs #92
Conversation
|
There is already basic coverage: https://github.com/bitcoin-core/qa-assets/tree/main/fuzz_seed_corpus/descriptor_parse So I presume you are extending it? |
|
Hmm, i'm not so good at english. What i meant here was to add initial coverage for miniscript descriptors, but yeah, it is extending the descriptors coverage with new inputs (those that contain miniscripts inside). |
|
Oh, I see. So this is exclusively adding inputs with miniscript coverage after bitcoin/bitcoin#24148 is merged? |
|
Yes. I initially seeded a folder with Miniscript descriptors and ran the fuzzer on it for a while. This is the minified version of the resulted folder. |
ffc79b8 qa: functional test Miniscript watchonly support (Antoine Poinsot) bfb0367 Miniscript support in output descriptors (Antoine Poinsot) 4a08288 qa: better error reporting on descriptor parsing error (Antoine Poinsot) d25d58b miniscript: add a helper to find the first insane sub with no child (Antoine Poinsot) c38c7c5 miniscript: don't check for top level validity at parsing time (Antoine Poinsot) Pull request description: This adds Miniscript support for Output Descriptors without any signing logic (yet). See the OP of #24147 for a description of Miniscript and a rationale of having it in Bitcoin Core. On its own, this PR adds "watchonly" support for Miniscript descriptors in the descriptor wallet. A follow-up adds signing support. A minified corpus of Miniscript Descriptors for the `descriptor_parse` fuzz target is available at bitcoin-core/qa-assets#92. The Miniscript descriptors used in the unit tests here and in #24149 were cross-tested against the Rust implementation at https://github.com/rust-bitcoin/rust-miniscript. This PR contains code and insights from Pieter Wuille. ACKs for top commit: Sjors: re-utACK ffc79b8 achow101: ACK ffc79b8 w0xlt: reACK bitcoin/bitcoin@ffc79b8 Tree-SHA512: 02d919d38bb626d3c557eca3680ce71117739fa161b7a92cfdb6c9c432ed88870b1ed127ba24248574c40c7428217d7e9bdd986fd8cd7c51fae8c776e1271fb9
|
Added some more seeds i've been generating in the background the past week(s). As a commit since it's not specific to Miniscript descriptors, it's extending the whole Marking as ready now that bitcoin/bitcoin#24148 is merged (:tada:). |
|
(I used a rebased bitcoin/bitcoin#25540 to generate and merge those.) |
|
|
How did you trigger this? I couldn't reproduce with on |
ffc79b8 qa: functional test Miniscript watchonly support (Antoine Poinsot) bfb0367 Miniscript support in output descriptors (Antoine Poinsot) 4a08288 qa: better error reporting on descriptor parsing error (Antoine Poinsot) d25d58b miniscript: add a helper to find the first insane sub with no child (Antoine Poinsot) c38c7c5 miniscript: don't check for top level validity at parsing time (Antoine Poinsot) Pull request description: This adds Miniscript support for Output Descriptors without any signing logic (yet). See the OP of bitcoin#24147 for a description of Miniscript and a rationale of having it in Bitcoin Core. On its own, this PR adds "watchonly" support for Miniscript descriptors in the descriptor wallet. A follow-up adds signing support. A minified corpus of Miniscript Descriptors for the `descriptor_parse` fuzz target is available at bitcoin-core/qa-assets#92. The Miniscript descriptors used in the unit tests here and in bitcoin#24149 were cross-tested against the Rust implementation at https://github.com/rust-bitcoin/rust-miniscript. This PR contains code and insights from Pieter Wuille. ACKs for top commit: Sjors: re-utACK ffc79b8 achow101: ACK ffc79b8 w0xlt: reACK bitcoin@ffc79b8 Tree-SHA512: 02d919d38bb626d3c557eca3680ce71117739fa161b7a92cfdb6c9c432ed88870b1ed127ba24248574c40c7428217d7e9bdd986fd8cd7c51fae8c776e1271fb9
|
It needs the The input that triggers this is |
|
Err, right.. 😅 |
|
Now it times out due to the timeout issue |
|
Yes, we need bitcoin/bitcoin#25540 in first |
No description provided.