ci: Use correct variable to designate C++ compiler #73

hebasto · 2022-10-19T15:07:07Z

Setting the CC variable does not affect the choice of a C++ compiler. CXX does.

On the master branch (c36f1f0), CI tasks, which are supposed to compile using a non-default compiler (e.g., clang), actually are configured to use the default compiler. For example, https://api.cirrus-ci.com/v1/task/5042259930906624/logs/test.log:

+ clang -v
Debian clang version 11.0.1-2
Target: x86_64-pc-linux-gnu
...
Build Options:
  with benchmarks         = yes
  with tests              = yes
  enable clmul fields     = yes
  CXX                     = g++ -std=c++11
...

maflcko · 2023-12-12T08:02:21Z

Looks like CI didn't run?

maflcko · 2024-04-03T14:55:29Z

@hebasto Maybe rebase for the CI to run?

hebasto · 2024-04-03T15:10:45Z

Maybe rebase for the CI to run?

Rebased.

maflcko · 2024-04-03T15:26:28Z


/usr/bin/ld: cannot find /usr/lib/llvm-14/lib/clang/14.0.6/lib/linux/libclang_rt.ubsan_standalone-x86_64.a: No such file or directory
/usr/bin/ld: cannot find /usr/lib/llvm-14/lib/clang/14.0.6/lib/linux/libclang_rt.ubsan_standalone_cxx-x86_64.a: No such file or directory

maflcko · 2024-04-03T15:53:57Z

.cirrus.yml

    - env:
-        CC: clang
+        CXX: clang++


Suggested change

CXX: clang++

CXX: clang++ -gdwarf-4

This is temporarily needed for valgrind. See the error:

+ valgrind --error-exitcode=42 ./test 1 ==4991== Memcheck, a memory error detector ==4991== Copyright (C) 2002-2022, and GNU GPL'd, by Julian Seward et al. ==4991== Using Valgrind-3.19.0 and LibVEX; rerun with -h for copyright info ==4991== Command: ./test 1 ==4991== ### unhandled dwarf2 abbrev form code 0x25 ### unhandled dwarf2 abbrev form code 0x25 ### unhandled dwarf2 abbrev form code 0x25 ### unhandled dwarf2 abbrev form code 0x23 ### unhandled dwarf2 abbrev form code 0x25 ### unhandled dwarf2 abbrev form code 0x25 ### unhandled dwarf2 abbrev form code 0x25 ### unhandled dwarf2 abbrev form code 0x23 ==4991== Valgrind: debuginfo reader: ensure_valid failed: ==4991== Valgrind: during call to ML_(img_get) ==4991== Valgrind: request for range [822865493, +4) exceeds ==4991== Valgrind: valid image size of 29291312 for image: ==4991== Valgrind: "/tmp/cirrus-ci-build/test" ==4991== ==4991== Valgrind: debuginfo reader: Possibly corrupted debuginfo file. ==4991== Valgrind: I can't recover. Giving up. Sorry. ==4991==

Thanks! Done.

maflcko · 2024-04-03T16:43:05Z

+ wine ./test
it looks like wine32 is missing, you should install it.
as root, please execute "apt-get install wine32:i386"
wine: failed to open "./test": c0000135

maflcko · 2024-04-04T06:09:45Z

Concept ACK. Haven't reviewed. I presume the qemu-s390x failure will fix itself once debian stable is rolled.

maflcko · 2024-04-04T06:10:57Z

cc @theuni as potential reviewer

theuni · 2024-04-05T20:30:52Z

Whoops! Nice catch.

Concept ACK. Looks like there are still a few legit c-i issues to fixup.

sipa · 2024-04-10T07:04:32Z

utACK e051a7d

83d812ea9f Merge bitcoin-core/minisketch#73: ci: Use correct variable to designate C++ compiler e051a7d690 ci: Install wine32 package for Windows tests 2d2c695d78 build: Drop unused `CC` variable 1810fcbd11 ci: Use correct variable to designate C++ compiler 022b959049 Merge bitcoin-core/minisketch#77: Add missing include 08443c4892 Add missing include git-subtree-dir: src/minisketch git-subtree-split: 83d812ea9f39d8b956aa0e27a676f7f390418a18

67b87acdb6 Merge bitcoin-core/minisketch#78: ci: Update macOS image for CI 7de7250416 ci: Update macOS image for CI 83d812ea9f Merge bitcoin-core/minisketch#73: ci: Use correct variable to designate C++ compiler e051a7d690 ci: Install wine32 package for Windows tests 2d2c695d78 build: Drop unused `CC` variable 1810fcbd11 ci: Use correct variable to designate C++ compiler 022b959049 Merge bitcoin-core/minisketch#77: Add missing include 08443c4892 Add missing include git-subtree-dir: src/minisketch git-subtree-split: 67b87acdb68587683a820743c476ec6159122293

4a48f31a37 Merge bitcoin-core/minisketch#83: ci: Fix "s390x (big-endian)" task 0498084d31 ci: Fix "s390x (big-endian)" task 71709dca9e Merge bitcoin-core/minisketch#82: ci: Fix `x86_64-w64-mingw32` task 9e6127fa98 Merge bitcoin-core/minisketch#74: Avoid >> above type width in BitWriter ed420bc170 ci: Fix `x86_64-w64-mingw32` task fe1040f227 Drop -Wno-shift-count-overflow compile flag 154bcd43bd Avoid >> above type width in BitWriter 67b87acdb6 Merge bitcoin-core/minisketch#78: ci: Update macOS image for CI 7de7250416 ci: Update macOS image for CI 83d812ea9f Merge bitcoin-core/minisketch#73: ci: Use correct variable to designate C++ compiler e051a7d690 ci: Install wine32 package for Windows tests 2d2c695d78 build: Drop unused `CC` variable 1810fcbd11 ci: Use correct variable to designate C++ compiler 022b959049 Merge bitcoin-core/minisketch#77: Add missing include 08443c4892 Add missing include git-subtree-dir: src/minisketch git-subtree-split: 4a48f31a3753534e26daabfdb42768c6236395ea

33b7c200b9 Merge bitcoin-core/minisketch#80: Add c++20 version of CountBits 4a48f31a37 Merge bitcoin-core/minisketch#83: ci: Fix "s390x (big-endian)" task 82b6488acb Add c++20 version of CountBits 0498084d31 ci: Fix "s390x (big-endian)" task 71709dca9e Merge bitcoin-core/minisketch#82: ci: Fix `x86_64-w64-mingw32` task 9e6127fa98 Merge bitcoin-core/minisketch#74: Avoid >> above type width in BitWriter ed420bc170 ci: Fix `x86_64-w64-mingw32` task fe1040f227 Drop -Wno-shift-count-overflow compile flag 154bcd43bd Avoid >> above type width in BitWriter 67b87acdb6 Merge bitcoin-core/minisketch#78: ci: Update macOS image for CI 7de7250416 ci: Update macOS image for CI 83d812ea9f Merge bitcoin-core/minisketch#73: ci: Use correct variable to designate C++ compiler e051a7d690 ci: Install wine32 package for Windows tests 2d2c695d78 build: Drop unused `CC` variable 1810fcbd11 ci: Use correct variable to designate C++ compiler 022b959049 Merge bitcoin-core/minisketch#77: Add missing include 08443c4892 Add missing include git-subtree-dir: src/minisketch git-subtree-split: 33b7c200b97498139aa1462a0dd0d6eba49d98b7

3472e2f5ec Merge bitcoin-core/minisketch#81: Avoid overflowing shift by special casing inverse of 1 653d8b2e26 Avoid overflowing shift by special casing inverse of 1 33b7c200b9 Merge bitcoin-core/minisketch#80: Add c++20 version of CountBits 4a48f31a37 Merge bitcoin-core/minisketch#83: ci: Fix "s390x (big-endian)" task 82b6488acb Add c++20 version of CountBits 0498084d31 ci: Fix "s390x (big-endian)" task 71709dca9e Merge bitcoin-core/minisketch#82: ci: Fix `x86_64-w64-mingw32` task 9e6127fa98 Merge bitcoin-core/minisketch#74: Avoid >> above type width in BitWriter ed420bc170 ci: Fix `x86_64-w64-mingw32` task fe1040f227 Drop -Wno-shift-count-overflow compile flag 154bcd43bd Avoid >> above type width in BitWriter 67b87acdb6 Merge bitcoin-core/minisketch#78: ci: Update macOS image for CI 7de7250416 ci: Update macOS image for CI 83d812ea9f Merge bitcoin-core/minisketch#73: ci: Use correct variable to designate C++ compiler e051a7d690 ci: Install wine32 package for Windows tests 2d2c695d78 build: Drop unused `CC` variable 1810fcbd11 ci: Use correct variable to designate C++ compiler 022b959049 Merge bitcoin-core/minisketch#77: Add missing include 08443c4892 Add missing include git-subtree-dir: src/minisketch git-subtree-split: 3472e2f5ec75ace39ce9243af6b3fee233a67492

eb37a9b8e Merge bitcoin-core/minisketch#87: Avoid copy in self-assign fe6557642 Merge bitcoin-core/minisketch#88: build: Add `-Wundef` 8ea298bfa Avoid copy in self-assign 978a3d886 build: Add `-Wundef` 338704417 Merge bitcoin-core/minisketch#86: doc: fix typo in sketch_impl.h 15c2d13b6 doc: fix typo in sketch_impl.h 7be08b8a4 Merge bitcoin-core/minisketch#85: Fixes for integer precision loss 00fb4a4d8 Avoid or make integer precision conversion explicit 9d62a4d27 Avoid the need to cast/convert to size_t for vector operations 19e06cc7a Prevent overflows from large capacity/max_elements 3472e2f5e Merge bitcoin-core/minisketch#81: Avoid overflowing shift by special casing inverse of 1 653d8b2e2 Avoid overflowing shift by special casing inverse of 1 33b7c200b Merge bitcoin-core/minisketch#80: Add c++20 version of CountBits 4a48f31a3 Merge bitcoin-core/minisketch#83: ci: Fix "s390x (big-endian)" task 82b6488ac Add c++20 version of CountBits 0498084d3 ci: Fix "s390x (big-endian)" task 71709dca9 Merge bitcoin-core/minisketch#82: ci: Fix `x86_64-w64-mingw32` task 9e6127fa9 Merge bitcoin-core/minisketch#74: Avoid >> above type width in BitWriter ed420bc17 ci: Fix `x86_64-w64-mingw32` task fe1040f22 Drop -Wno-shift-count-overflow compile flag 154bcd43b Avoid >> above type width in BitWriter 67b87acdb Merge bitcoin-core/minisketch#78: ci: Update macOS image for CI 7de725041 ci: Update macOS image for CI 83d812ea9 Merge bitcoin-core/minisketch#73: ci: Use correct variable to designate C++ compiler e051a7d69 ci: Install wine32 package for Windows tests 2d2c695d7 build: Drop unused `CC` variable 1810fcbd1 ci: Use correct variable to designate C++ compiler 022b95904 Merge bitcoin-core/minisketch#77: Add missing include 08443c489 Add missing include a571ba20f Merge bitcoin-core/minisketch#68: Add missed `#include <string>` b9a7f7e2b Merge bitcoin-core/minisketch#69: refactor: Drop unused `total` local variables 8a5af94ed Merge bitcoin-core/minisketch#70: build: Remove `-Qunused-arguments` workaround for clang + ccache c36f1f03a Merge bitcoin-core/minisketch#72: Fix MSVC implementation of `CountBits()` function 0078bedda Ignore `HAVE_CLZ` macro when building with MSVC 1c772918c Fix MSVC implementation of `CountBits()` function 98f87c55f build: Remove `-Qunused-arguments` workaround for clang + ccache 11a1e25c8 refactor: Drop unused `total` local variables ed6c8fcfd Add missed `#include <string>` 47f0a2d26 Merge bitcoin-core/minisketch#66: msvc: remove direct Bitcoin Core `compat.h` include 64f17584c msvc: remove Core compat.h include git-subtree-dir: src/minisketch git-subtree-split: eb37a9b8e79f9e49d73b96a49bf97a96d9eb676c

3472e2f5ec Merge bitcoin-core/minisketch#81: Avoid overflowing shift by special casing inverse of 1 653d8b2e26 Avoid overflowing shift by special casing inverse of 1 33b7c200b9 Merge bitcoin-core/minisketch#80: Add c++20 version of CountBits 4a48f31a37 Merge bitcoin-core/minisketch#83: ci: Fix "s390x (big-endian)" task 82b6488acb Add c++20 version of CountBits 0498084d31 ci: Fix "s390x (big-endian)" task 71709dca9e Merge bitcoin-core/minisketch#82: ci: Fix `x86_64-w64-mingw32` task 9e6127fa98 Merge bitcoin-core/minisketch#74: Avoid >> above type width in BitWriter ed420bc170 ci: Fix `x86_64-w64-mingw32` task fe1040f227 Drop -Wno-shift-count-overflow compile flag 154bcd43bd Avoid >> above type width in BitWriter 67b87acdb6 Merge bitcoin-core/minisketch#78: ci: Update macOS image for CI 7de7250416 ci: Update macOS image for CI 83d812ea9f Merge bitcoin-core/minisketch#73: ci: Use correct variable to designate C++ compiler e051a7d690 ci: Install wine32 package for Windows tests 2d2c695d78 build: Drop unused `CC` variable 1810fcbd11 ci: Use correct variable to designate C++ compiler 022b959049 Merge bitcoin-core/minisketch#77: Add missing include 08443c4892 Add missing include git-subtree-dir: src/minisketch git-subtree-split: 3472e2f5ec75ace39ce9243af6b3fee233a67492

hebasto mentioned this pull request Mar 7, 2023

ci: Update macOS image for CI #78

Merged

hebasto force-pushed the 221019-ci-cxx branch from 7ae39e1 to 59164ba Compare April 3, 2024 15:09

hebasto force-pushed the 221019-ci-cxx branch from 59164ba to ee39c6c Compare April 3, 2024 15:37

maflcko reviewed Apr 3, 2024

View reviewed changes

hebasto added 2 commits April 3, 2024 17:00

ci: Use correct variable to designate C++ compiler

1810fcb

build: Drop unused CC variable

2d2c695

hebasto force-pushed the 221019-ci-cxx branch from ee39c6c to 2d2c695 Compare April 3, 2024 16:01

ci: Install wine32 package for Windows tests

e051a7d

sipa merged commit 83d812e into bitcoin-core:master Apr 10, 2024

hebasto deleted the 221019-ci-cxx branch April 10, 2024 07:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci: Use correct variable to designate C++ compiler #73

ci: Use correct variable to designate C++ compiler #73

Uh oh!

hebasto commented Oct 19, 2022 •

edited

Loading

Uh oh!

maflcko commented Dec 12, 2023

Uh oh!

maflcko commented Apr 3, 2024

Uh oh!

hebasto commented Apr 3, 2024

Uh oh!

maflcko commented Apr 3, 2024

Uh oh!

maflcko Apr 3, 2024

Uh oh!

maflcko Apr 3, 2024

Uh oh!

hebasto Apr 3, 2024

Uh oh!

maflcko commented Apr 3, 2024

Uh oh!

maflcko commented Apr 4, 2024

Uh oh!

maflcko commented Apr 4, 2024

Uh oh!

theuni commented Apr 5, 2024

Uh oh!

sipa commented Apr 10, 2024

Uh oh!

Uh oh!

ci: Use correct variable to designate C++ compiler #73

ci: Use correct variable to designate C++ compiler #73

Uh oh!

Conversation

hebasto commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maflcko commented Dec 12, 2023

Uh oh!

maflcko commented Apr 3, 2024

Uh oh!

hebasto commented Apr 3, 2024

Uh oh!

maflcko commented Apr 3, 2024

Uh oh!

maflcko Apr 3, 2024

Choose a reason for hiding this comment

Uh oh!

maflcko Apr 3, 2024

Choose a reason for hiding this comment

Uh oh!

hebasto Apr 3, 2024

Choose a reason for hiding this comment

Uh oh!

maflcko commented Apr 3, 2024

Uh oh!

maflcko commented Apr 4, 2024

Uh oh!

maflcko commented Apr 4, 2024

Uh oh!

theuni commented Apr 5, 2024

Uh oh!

sipa commented Apr 10, 2024

Uh oh!

Uh oh!

hebasto commented Oct 19, 2022 •

edited

Loading