Move #ifdef HAVE_CLMUL guard outside of the EnableClmul definition
#58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the EnableClmul() function call sites are guarded by the HAVE_CLMUL macro. Using the same guarding for its definition gets rid of a possible `-Wunused-function` compiler warning.
|
utACK 4d9db2b |
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Feb 4, 2022
7eeb778fef Merge bitcoin-core/minisketch#58: Move `#ifdef HAVE_CLMUL` guard outside of the EnableClmul definition 4d9db2b897 Move `#ifdef HAVE_CLMUL` guard outside of the EnableClmul definition git-subtree-dir: src/minisketch git-subtree-split: 7eeb778fef45e21abca01ede85cf0a82e8a510df
maflcko
pushed a commit
to bitcoin/bitcoin
that referenced
this pull request
Feb 4, 2022
8fcb19f Squashed 'src/minisketch/' changes from 89629eb2c7..7eeb778fef (fanquake) Pull request description: Marco mentioned issues running the native valgrind job (it sets `-Werror`) on arm64 hardware due to compile errors: ```bash minisketch/src/minisketch.cpp:66:20: error: unused function 'EnableClmul' [-Werror,-Wunused-function] ``` Pull the subtree to fix this. The only change here is bitcoin-core/minisketch#58. ACKs for top commit: MarcoFalke: cr ACK 4382d09 Tree-SHA512: 8dbb2d8a4269e187987a9e6084c6265ed8256859b0776474c2d332df64427cd55608932e1e2053dcc3d8d1699a82c667afae20c3db7a35407bea662ada65a5f7
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 6, 2022
8fcb19f Squashed 'src/minisketch/' changes from 89629eb2c7..7eeb778fef (fanquake) Pull request description: Marco mentioned issues running the native valgrind job (it sets `-Werror`) on arm64 hardware due to compile errors: ```bash minisketch/src/minisketch.cpp:66:20: error: unused function 'EnableClmul' [-Werror,-Wunused-function] ``` Pull the subtree to fix this. The only change here is bitcoin-core/minisketch#58. ACKs for top commit: MarcoFalke: cr ACK 4382d09 Tree-SHA512: 8dbb2d8a4269e187987a9e6084c6265ed8256859b0776474c2d332df64427cd55608932e1e2053dcc3d8d1699a82c667afae20c3db7a35407bea662ada65a5f7
sh15h4nk
pushed a commit
to sh15h4nk/bitcoin
that referenced
this pull request
Feb 13, 2022
7eeb778fef Merge bitcoin-core/minisketch#58: Move `#ifdef HAVE_CLMUL` guard outside of the EnableClmul definition 4d9db2b897 Move `#ifdef HAVE_CLMUL` guard outside of the EnableClmul definition git-subtree-dir: src/minisketch git-subtree-split: 7eeb778fef45e21abca01ede85cf0a82e8a510df
rebroad
pushed a commit
to rebroad/bitcoin
that referenced
this pull request
Feb 15, 2022
7eeb778fef Merge bitcoin-core/minisketch#58: Move `#ifdef HAVE_CLMUL` guard outside of the EnableClmul definition 4d9db2b897 Move `#ifdef HAVE_CLMUL` guard outside of the EnableClmul definition git-subtree-dir: src/minisketch git-subtree-split: 7eeb778fef45e21abca01ede85cf0a82e8a510df
janus
pushed a commit
to BitgesellOfficial/bitgesell
that referenced
this pull request
Jul 24, 2022
7eeb778fef Merge bitcoin-core/minisketch#58: Move `#ifdef HAVE_CLMUL` guard outside of the EnableClmul definition 4d9db2b897 Move `#ifdef HAVE_CLMUL` guard outside of the EnableClmul definition git-subtree-dir: src/minisketch git-subtree-split: 7eeb778fef45e21abca01ede85cf0a82e8a510df
backpacker69
pushed a commit
to peercoin/peercoin
that referenced
this pull request
Jan 18, 2023
7eeb778fef Merge bitcoin-core/minisketch#58: Move `#ifdef HAVE_CLMUL` guard outside of the EnableClmul definition 4d9db2b897 Move `#ifdef HAVE_CLMUL` guard outside of the EnableClmul definition git-subtree-dir: src/minisketch git-subtree-split: 7eeb778fef45e21abca01ede85cf0a82e8a510df
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Oct 20, 2024
7eeb778fef Merge bitcoin-core/minisketch#58: Move `#ifdef HAVE_CLMUL` guard outside of the EnableClmul definition 4d9db2b897 Move `#ifdef HAVE_CLMUL` guard outside of the EnableClmul definition git-subtree-dir: src/minisketch git-subtree-split: 7eeb778fef45e21abca01ede85cf0a82e8a510df
rebroad
pushed a commit
to rebroad/bitcoin
that referenced
this pull request
Mar 29, 2025
7eeb778fef Merge bitcoin-core/minisketch#58: Move `#ifdef HAVE_CLMUL` guard outside of the EnableClmul definition 4d9db2b897 Move `#ifdef HAVE_CLMUL` guard outside of the EnableClmul definition git-subtree-dir: src/minisketch git-subtree-split: 7eeb778fef45e21abca01ede85cf0a82e8a510df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the
EnableClmul()function call sites are guarded by theHAVE_CLMULmacro. Using the same guarding for its definition gets rid of a possible-Wunused-functioncompiler warning.Closes #53.