Errors when building with MSVC #67
Description
There is a minisketch_tests.cpp test in the Bitcoin Core project. Being built with MSVC, it fails in different scenarios:
- test: minisketch decode returns empty optional bitcoin/bitcoin#24664
- test:
minisketch_tests.cppcan fail when built with MSVC bitcoin/bitcoin#26262
A similar issue has been observed when using experimental CMake-based build system as well.
Another simple way to reproduce the issue is to build libminisketch without clmul instructions support, see this branch:
C:\Users\hebasto\bitcoin>build_msvc\x64\Release\test_bitcoin.exe -t minisketch_tests
Running 1 test case...
C:/Users/hebasto/bitcoin/src/test/minisketch_tests.cpp(43): fatal error: in "minisketch_tests/minisketch_test": critical check dec.has_value() has failed
*** 1 failure is detected in the test module "Bitcoin Core Test Suite"
C:\Users\hebasto\bitcoin>msbuild --version
Microsoft (R) Build Engine version 17.2.1+52cd2da31 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.
17.2.1.25201
UPDATE: also see #67 (comment)