Skip to content

Conversation

ryanofsky
Copy link
Collaborator

@ryanofsky ryanofsky commented Mar 3, 2020

No description provided.

@ryanofsky ryanofsky mentioned this pull request Mar 3, 2020
@Sjors
Copy link
Member

Sjors commented Mar 3, 2020

That did the trick for me, although (perhaps unrelated), make test says it can't find any.

@ryanofsky
Copy link
Collaborator Author

That did the trick for me, although (perhaps unrelated), make test says it can't find any.

Thanks for testing! make test not doing anything is expected because ubuntu 0.6.1 package doesn't include the libkj-test library, so the mptest build is skipped

@Sjors
Copy link
Member

Sjors commented Mar 3, 2020

This also fixed #26, except for make test, which throws

Test project /Users/sjors/dev/libmultiprocess/build
    Start 1: mptest
Could not find executable /Users/sjors/dev/libmultiprocess/build/mptest
Looked in the following places:
/Users/sjors/dev/libmultiprocess/build/mptest
....
Unable to find executable: /Users/sjors/dev/libmultiprocess/build/mptest
1/1 Test #1: mptest ...........................***Not Run   0.00 sec

0% tests passed, 1 tests failed out of 1

@ryanofsky
Copy link
Collaborator Author

make test says it can't find any.

To clarify, if you're seeing error:

No tests were found!!!

with capnp 0.6.1 this is expected because the test can't be built.

But if you're seeing:

The following tests FAILED:
          1 - mptest (Not Run)
Errors while running CTest

that's a different problem. You need to run make all test instead of make test in that case (https://stackoverflow.com/questions/733475/cmake-ctest-make-test-doesnt-build-tests). I'll update the readme to reflect this

@ryanofsky ryanofsky merged commit 4d78645 into bitcoin-core:master Mar 4, 2020
@bitcoin-core bitcoin-core locked and limited conversation to collaborators Jun 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants