Add support for vector<bool> serialization #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to support vector<bool> txout_is_change field added in bitcoin-core/gui#119
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Sep 28, 2023
Update libmultiprocess to include newer changes: - "Remove naming requirement for std::pair/std::tuple" (bitcoin-core/libmultiprocess#85) To support adding a src/ipc/capnp/chain.capnp RPCArg struct which is mapped to a std::pair in a upcoming commit. - Add support for vector<bool> serialization (bitcoin-core/libmultiprocess#86) To support adding serializing recently-added vector<bool> txout_is_change.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Oct 20, 2023
Update libmultiprocess to include newer changes: - "Remove naming requirement for std::pair/std::tuple" (bitcoin-core/libmultiprocess#85) To support adding a src/ipc/capnp/chain.capnp RPCArg struct which is mapped to a std::pair in a upcoming commit. - Add support for vector<bool> serialization (bitcoin-core/libmultiprocess#86) To support adding serializing recently-added vector<bool> txout_is_change.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Oct 20, 2023
Update libmultiprocess to include newer changes: - "Remove naming requirement for std::pair/std::tuple" (bitcoin-core/libmultiprocess#85) To support adding a src/ipc/capnp/chain.capnp RPCArg struct which is mapped to a std::pair in a upcoming commit. - Add support for vector<bool> serialization (bitcoin-core/libmultiprocess#86) To support adding serializing recently-added vector<bool> txout_is_change.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Oct 24, 2023
Update libmultiprocess to include newer changes: - "Remove naming requirement for std::pair/std::tuple" (bitcoin-core/libmultiprocess#85) To support adding a src/ipc/capnp/chain.capnp RPCArg struct which is mapped to a std::pair in a upcoming commit. - Add support for vector<bool> serialization (bitcoin-core/libmultiprocess#86) To support adding serializing recently-added vector<bool> txout_is_change.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Oct 24, 2023
Update libmultiprocess to include newer changes: - "Remove naming requirement for std::pair/std::tuple" (bitcoin-core/libmultiprocess#85) To support adding a src/ipc/capnp/chain.capnp RPCArg struct which is mapped to a std::pair in a upcoming commit. - Add support for vector<bool> serialization (bitcoin-core/libmultiprocess#86) To support adding serializing recently-added vector<bool> txout_is_change.
ryanofsky
added a commit
to ryanofsky/libmultiprocess
that referenced
this pull request
Jan 22, 2024
The vector<bool> serialization supported added in bitcoin-core#86 commit 1c6fb04 was only tested with libstdc++ not libc++ and caused a test compilation failure when compiling on macos, reported by edilmedeiros in bitcoin-core#92 Fix the issue that was causing the build to fail: trying to use using vector's reference type instead of const_reference type when serializing the vector. Fixes bitcoin-core#92
ryanofsky
added a commit
that referenced
this pull request
Jan 22, 2024
10fc3ed Fix support for vector<bool> serialization with libc++ (Ryan Ofsky) Pull request description: The vector<bool> serialization supported added in #86 commit 1c6fb04 was only tested with libstdc++ not libc++ and caused a test compilation failure when compiling on macos, reported by edilmedeiros in #92 Fix the issue that was causing the build to fail: trying to use using vector's reference type instead of const_reference type when serializing the vector. Fixes #92 Top commit has no ACKs. Tree-SHA512: ad295f384fd10be94640809877a8e04d280ab837348ed3427b5c0eeae244f86c092048e148ffe7d37de10d0caa6a38a0839910481fdff711e0ab9ac18eb2a784
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to support
vector<bool>txout_is_changefield added in bitcoin-core/gui#119