Remove naming requirement for std::pair/std::tuple #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting C++ std::pair and length 2 std::tuple values to and from capn'proto structs, no longer require the struct to have fields named "key" and "value". Instead always map the first pair/tuple element to the first struct field, and the second element to the second field. This allows anonymous std::pair and std::tuple types used in the C++ interface to have names and custom Read/Build logic when they are serialized as capn'proto messages. For now only length-2 tuples are supported but this could be extended to support converting c++ tuples of arbitrary length to capn'proto structs with the same number of fields.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Sep 20, 2023
Update libmultiprocess to include change "Remove naming requirement for std::pair/std::tuple" bitcoin-core/libmultiprocess#85 needed to support src/ipc/capnp/chain.capn RPCArg struct which is mapped to a std::pair in an upcoming commit.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Sep 26, 2023
Update libmultiprocess to include change "Remove naming requirement for std::pair/std::tuple" bitcoin-core/libmultiprocess#85 needed to support src/ipc/capnp/chain.capn RPCArg struct which is mapped to a std::pair in an upcoming commit.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Sep 26, 2023
Update libmultiprocess to include change "Remove naming requirement for std::pair/std::tuple" bitcoin-core/libmultiprocess#85 needed to support src/ipc/capnp/chain.capn RPCArg struct which is mapped to a std::pair in an upcoming commit.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Sep 28, 2023
Update libmultiprocess to include newer changes: - "Remove naming requirement for std::pair/std::tuple" (bitcoin-core/libmultiprocess#85) To support adding a src/ipc/capnp/chain.capnp RPCArg struct which is mapped to a std::pair in a upcoming commit. - Add support for vector<bool> serialization (bitcoin-core/libmultiprocess#86) To support adding serializing recently-added vector<bool> txout_is_change.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Oct 20, 2023
Update libmultiprocess to include newer changes: - "Remove naming requirement for std::pair/std::tuple" (bitcoin-core/libmultiprocess#85) To support adding a src/ipc/capnp/chain.capnp RPCArg struct which is mapped to a std::pair in a upcoming commit. - Add support for vector<bool> serialization (bitcoin-core/libmultiprocess#86) To support adding serializing recently-added vector<bool> txout_is_change.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Oct 20, 2023
Update libmultiprocess to include newer changes: - "Remove naming requirement for std::pair/std::tuple" (bitcoin-core/libmultiprocess#85) To support adding a src/ipc/capnp/chain.capnp RPCArg struct which is mapped to a std::pair in a upcoming commit. - Add support for vector<bool> serialization (bitcoin-core/libmultiprocess#86) To support adding serializing recently-added vector<bool> txout_is_change.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Oct 24, 2023
Update libmultiprocess to include newer changes: - "Remove naming requirement for std::pair/std::tuple" (bitcoin-core/libmultiprocess#85) To support adding a src/ipc/capnp/chain.capnp RPCArg struct which is mapped to a std::pair in a upcoming commit. - Add support for vector<bool> serialization (bitcoin-core/libmultiprocess#86) To support adding serializing recently-added vector<bool> txout_is_change.
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Oct 24, 2023
Update libmultiprocess to include newer changes: - "Remove naming requirement for std::pair/std::tuple" (bitcoin-core/libmultiprocess#85) To support adding a src/ipc/capnp/chain.capnp RPCArg struct which is mapped to a std::pair in a upcoming commit. - Add support for vector<bool> serialization (bitcoin-core/libmultiprocess#86) To support adding serializing recently-added vector<bool> txout_is_change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting C++ std::pair and length 2 std::tuple values to and from capn'proto structs, no longer require the struct to have fields named "key" and "value". Instead always map the first pair/tuple element to the first struct field, and the second element to the second field.
This allows anonymous std::pair and std::tuple types used in the C++ interface to have names and custom Read/Build logic when they are serialized as capn'proto messages.
For now only length-2 tuples are supported but this could be extended to support converting c++ tuples of arbitrary length to capn'proto structs with the same number of fields.