Skip to content

Conversation

ryanofsky
Copy link
Collaborator

Preemptively avoid clang-tidy errors before clang-tidy is introduced in #83. Other clang errors are already fixed in that PR, but these aren't maybe due to running different clang-tidy versions. The errors look like:

include/mp/proxy-types.h:162:85: warning: the parameter 'perhaps' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
                            .then([&server, invoke, req](kj::Maybe<Thread::Server&> perhaps) {
                                                                                    ^
                                                         const                     &
example/printer.cpp:27:39: warning: the parameter 'message' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void LogPrint(bool raise, std::string message)
                                      ^
example/printer.cpp:29:41: warning: passing result of std::move() as a const reference argument; no move will actually happen [performance-move-const-arg]
    if (raise) throw std::runtime_error(std::move(message));
                                        ^~~~~~~~~~       ~

Preemptively avoid clang-tidy errors before clang-tidy is introduced in
bitcoin-core#83. Other clang errors
are already fixed in that PR, these aren't (maybe due to running different
clang-tidy versions). The errors look like:

include/mp/proxy-types.h:162:85: warning: the parameter 'perhaps' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
                            .then([&server, invoke, req](kj::Maybe<Thread::Server&> perhaps) {
                                                                                    ^
                                                         const                     &
example/printer.cpp:27:39: warning: the parameter 'message' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void LogPrint(bool raise, std::string message)
                                      ^
example/printer.cpp:29:41: warning: passing result of std::move() as a const reference argument; no move will actually happen [performance-move-const-arg]
    if (raise) throw std::runtime_error(std::move(message));
                                        ^~~~~~~~~~       ~
@ryanofsky ryanofsky merged commit 74e25d2 into bitcoin-core:master Feb 14, 2023
@bitcoin-core bitcoin-core locked and limited conversation to collaborators Jun 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant