Support attaching custom cleanup functions to proxy client and server classes #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No change in behavior
Support attaching custom cleanup functions to proxy client and server classes
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jan 28, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 4, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 4, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 4, 2021
Update libmultiprocess library Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 17, 2021
Update libmultiprocess library Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 17, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 17, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 30, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 30, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ariard
pushed a commit
to ariard/bitcoin
that referenced
this pull request
Apr 6, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Apr 23, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Apr 23, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the need to add interface base classes with
addCloseHookmethods in bitcoin/bitcoin#19160 and bitcoin/bitcoin#10102