Skip to content

Remove the deprecated OSMemoryBarrier #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove the deprecated OSMemoryBarrier #20

wants to merge 1 commit into from

Conversation

DesWurstes
Copy link

It said:

./port/atomic_pointer.h:55:3: warning: 'OSMemoryBarrier' is deprecated: first
      deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic>
      instead [-Wdeprecated-declarations]
  OSMemoryBarrier();

The upstream LevelDB already replaced it with std::atomic_thread_fence(std::memory_order_seq_cst);

In addition, I found the definition of OSMemoryBarrier(), it calls the same function:

OSATOMIC_INLINE
void
OSMemoryBarrier(void)
{
	OSATOMIC_STD(atomic_thread_fence)(OSATOMIC_STD(memory_order_seq_cst));
}

@ken2812221
Copy link

utACK 7d9b387

@laanwj
Copy link
Member

laanwj commented Jan 16, 2019

utACK (though we should probably update from upstream, if this is fixed upstream?)

@fanquake
Copy link
Member

Upstream has merged google@594cc98, and there is still google#449 open.

@laanwj
Copy link
Member

laanwj commented Nov 6, 2019

I'd really prefer updating to upstream (#25) instead of carrying more patches, which will make future upstream updates even more involved.

@laanwj laanwj closed this Nov 6, 2019
@laanwj laanwj mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DesWurstes @ken2812221 @laanwj @fanquake