This repository was archived by the owner on Jun 17, 2019. It is now read-only.
leveldb: Win32WritableFile without memory mapping #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a straightforward Win32WritableFile for writing files, equivalent to PosixWritableFile in posix_env.cc, but using only the Win32 API. The goal is to solve leveldb corruption issues on windows after crashes, which are frequently reported.
|
utACK* (I don't consider myself at all familiar with leveldb internally, but this looks reasonable) |
|
@sipa how do we handle merging here? Better to have a merge commit or just cherry-pick on it top? Can you help with subtree-merging this back to bitcoin? I always get confused with git subtree. |
|
I'll deal with it. |
|
Tested ACK: this does not add any failing LevelDB unit tests when compiling with mingw and running under wine. A few of the corruption unit tests were already broken in this case, though. |
|
ut ACK |
sipa
added a commit
that referenced
this pull request
Nov 4, 2015
7aa105e leveldb: Win32WritableFile without memory mapping (Wladimir J. van der Laan)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a straightforward Win32WritableFile for writing files, equivalent to PosixWritableFile in posix_env.cc, but using only the Win32 API.
The goal is to solve leveldb corruption issues on windows after crashes, which are frequently reported.
See bitcoin/bitcoin#6917