Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Apr 13, 2023

This PR is a follow up of bitcoin/bitcoin#27217.

Fixes #725.

@hebasto hebasto added this to the 25.0 milestone Apr 13, 2023
@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 13, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK furszy, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@hebasto hebasto changed the title qt: Register wallet::AddressPurpose type Register wallet::AddressPurpose type Apr 13, 2023
Copy link
Member

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK a45b544

@achow101
Copy link
Member

ACK a45b544

@hebasto hebasto merged commit 19764dc into bitcoin-core:master Apr 13, 2023
@hebasto hebasto deleted the 230413-address branch April 13, 2023 13:42
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 13, 2023
a45b544 qt: Register `wallet::AddressPurpose` type (Hennadii Stepanov)

Pull request description:

  This PR is a follow up of bitcoin#27217.

  Fixes bitcoin#725.

ACKs for top commit:
  achow101:
    ACK a45b544
  furszy:
    Tested ACK a45b544

Tree-SHA512: c670f4bf56442613d3fe038b0ba21acfcd4c69aa5340072e9a77d83f5fab1bf2facd87a9e1f42d88f496d277b27b79e7090444d59a9b9e71f3b486e171daa669
@bitcoin-core bitcoin-core deleted a comment from bavr2020 Apr 20, 2023
@bitcoin-core bitcoin-core locked and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash using getnewaddress in the console
4 participants