Prevent wrong handling of %2 token by Transifex
#664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transifex must expect a `%2` token in the translated string, not a `%2GB` one.
|
ACK 8ed2b72 replace " GB" for "GB" (only here) after it is translated? |
Why? There is supposed to be a space...? |
jarolrod
approved these changes
Sep 9, 2022
|
I wasn't sure before, but yeah, it seems there is supposed to be a space. 👍
…On Thu, Sep 8, 2022 at 12:16 AM Luke Dashjr ***@***.***> wrote:
replace " GB" for "GB" (only here) after it is translated?
Why? There is supposed to be a space...?
—
Reply to this email directly, view it on GitHub
<#664 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMRS4W4EI2QBSAXABKBI7PDV5EH3DANCNFSM6AAAAAAQGR5QKU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 14, 2022
…ransifex 8ed2b72 qt: Prevent wrong handling of `%2` token by Transifex (Hennadii Stepanov) Pull request description: On master (124e75a), Transifex translation check fails for https://github.com/bitcoin-core/gui/blob/124e75a41ea0f3f0e90b63b0c41813184ddce2ab/src/qt/forms/intro.ui#L206 with a message: > The expression '%2G' is not present in the translation. In "Organization Settings" --> ["Translation checks"](https://www.transifex.com/bitcoin/settings/validations/) I have changed the status of the "**Variable substitution specifiers (like "%s") are preserved in the translations.**" check from "error" to "warning" temporarily. This setting should be reverted after applying this PR change. [Noted](https://www.transifex.com/bitcoin/bitcoin/translate/#ru/qt-translation-024x/436102928/) by Transifex user [AHOHNMYC](https://www.transifex.com/user/profile/AHOHNMYC/). I faced the same issue while working on Ukrainian translation. ACKs for top commit: katesalazar: ACK 8ed2b72 jarolrod: ACK 8ed2b72 Tree-SHA512: 304f795ac9241ac8453c614ed18d967226d9d515f9ea079b51af5bcbe2f0760ca7dcaea5efb38207720cb7a18159c2bcd337b961bc522a128715c70e0db81061
hebasto
added a commit
that referenced
this pull request
Sep 14, 2022
6725030 qt: Update translation source file for string freeze (round 2) (Hennadii Stepanov) Pull request description: On the day of [translation string freeze](bitcoin/bitcoin#24987 (comment)), it happened that #660 did not include new strings from bitcoin/bitcoin#19602. This PR includes all recent updates. As a Transifex translator, I believe it is enough time for all translators to handle a few new strings by a release date. Also a Transifex check failure has been [fixed](/pull/664). ACKs for top commit: jarolrod: ACK 6725030 Tree-SHA512: d57b841e87e389d31ec4ae9067b83f7f209e168399bc088c3234c2c66b34772739cb801f04b5038d55de115083d022d603bc976374bfd537b8ea10c10a545183
|
I wasn't sure before, but yeah, it seems there is supposed to be a space. 👍
…On Thu, Sep 8, 2022 at 12:16 AM Luke Dashjr ***@***.***> wrote:
replace " GB" for "GB" (only here) after it is translated?
Why? There is supposed to be a space...?
—
Reply to this email directly, view it on GitHub
<#664 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMRS4W4EI2QBSAXABKBI7PDV5EH3DANCNFSM6AAAAAAQGR5QKU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master (124e75a), Transifex translation check fails for
gui/src/qt/forms/intro.ui
Line 206 in 124e75a
In "Organization Settings" --> "Translation checks" I have changed the status of the "Variable substitution specifiers (like "%s") are preserved in the translations." check from "error" to "warning" temporarily. This setting should be reverted after applying this PR change.
Noted by Transifex user AHOHNMYC.
I faced the same issue while working on Ukrainian translation.