Getting ready to Qt 6 (9/n). Apply Qt 6 specific changes #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qt 6, registration of `QDataStream` streaming operators is done automatically. Consequently, `qRegisterMetaTypeStreamOperators()` does no longer exist. Calls to this method have to be removed when porting to Qt 6. See https://doc.qt.io/qt-6/qtcore-changes-qt6.html#the-qmetatype-class
In Qt 6, high DPI pixmaps and scaling are always enabled. https://doc.qt.io/qt-6/highdpi.html
13 tasks
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
jarolrod
reviewed
Jun 23, 2022
There was a problem hiding this comment.
Concept ACK, need to finish testing
-
- I have confirmed with Qt Docs that the commit description is correct and we do in fact need to remove the
qRegisterMetaTypeStreamOperatorwhen building with Qt6. The usage ofqRegisterMetaTypeis the appropriate call for Qt6.
- I have confirmed with Qt Docs that the commit description is correct and we do in fact need to remove the
-
- Confirmed with Qt docs that for Qt6 we should use
QLibraryInfo::pathinstead ofQLibraryInfo::location. The new code here is correct as we useQLibraryInfoPathand we pass in a valid::LibraryPathenum in::TranslationsPath
- Confirmed with Qt docs that for Qt6 we should use
-
- Confirming with Qtdocs that we don't need to set hidpi flags with Qt6: "... Qt 5 behavior assumes that AA_EnableHighDpiScaling has been set (this flag is not needed on Qt 6)"
jarolrod
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
ACK d8d99d0
Tested with Qt6 and the experimental Cmake branch and confirmed the window size and components look fine on a HIDPI and low dpi display. Also tested that I can still choose and switch through translations. Additionally, I performed a sanity check building with Qt5.
|
Code review ACK d8d99d0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more step in migration to Qt 6.
Could be tested with hebasto/bitcoin#3 or bitcoin/bitcoin#24798.
No behavior change when compiling with Qt 5.