Scale network graph based on time interval #539

RandyMcMillan · 2022-01-27T06:46:55Z

The Network Graph is updated to scale based on the time interval selected by the QSlider.
The graph now displays a sample history that is retained when the QSlider value is changed.
Fixes issue #532

RandyMcMillan · 2022-01-27T06:49:26Z

This is a short screen cast of the functionality.

Screen.Recording.2022-01-27.at.1.47.21.AM.mov

RandyMcMillan · 2022-01-27T13:46:32Z

Here it is retaining 5 1/2 hours of samples - still snappy.

Screen.Recording.2022-01-27.at.8.42.34.AM.mov

RandyMcMillan · 2022-01-27T14:10:07Z

Original issue description #7481 (2016)

bitcoin/bitcoin#7481

DrahtBot · 2022-01-27T21:17:12Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept ACK	jonatack, w0xlt

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#524 (Replace int with std::chrono in for the timer->setInterval() argument by shaavan)
#492 (Show ToolTip on Network Traffic graph by rebroad)
#484 (Don't clear traffic graph when changing interval by rebroad)
#473 (Enable a non-linear network traffic option (click to toggle between linear and non-linear) by rebroad)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

RandyMcMillan · 2022-01-28T07:17:29Z

Commit 4292212
takes the relevant samples from the global sample list to determine tmax - which is used to calculate the y axis'.

20220128021252941.mp4

RandyMcMillan · 2022-01-28T19:05:54Z

Implemented PR #473 Log Scale Toggle

20220128140238975.mp4

rsafier · 2022-01-29T00:03:50Z

tested it out and seemed to behave as expected.

jonatack · 2022-01-29T00:23:15Z

Concept ACK, thanks for tackling this. Will review/test shortly. Edit: initial testing looks good.

RandyMcMillan · 2022-01-29T09:39:49Z

commit 83e521c - attaches the scale toggle to a mouse double click event opposed to a single click event.
Toggling the scale is more intentional this way - plus it makes a single click event available for something more useful.

RandyMcMillan · 2022-01-29T13:24:21Z

In some of the previous screen shots - the colors look muddy - commit 8eeb1f1 adjusts the visual output to avoid the way the colors were mixing and creating a muddy effect.

commit-8eeb1f1.mp4

RandyMcMillan · 2022-01-29T19:12:47Z

I have more ideas related to the network graph - I will post a different PR based on this PR - with some other ideas...

w0xlt · 2022-01-30T15:23:31Z

Concept ACK

rebroad · 2022-02-01T09:32:45Z

src/qt/trafficgraphwidget.cpp

 void TrafficGraphWidget::paintEvent(QPaintEvent *)
 {
    QPainter painter(this);
    painter.fillRect(rect(), Qt::black);

    if(fMax <= 0.0f) return;

-    QColor axisCol(Qt::gray);
+    QColor axisCol(QColor(78,78,78,255));


I didn't check to see if there was a Qt defined dark gray - It is ideal to let the samples stand out above the scale lines - we can tweak this. Note: there is plenty of room unused in the side panel - I have some code laying around to define user preferred color palettes - could be a useful feature for usability/accessibility.

A thought was to implement Solarized Light/Dark color palettes as user options - I am a fan - and plenty of research has gone into these color schemes.

rebroad · 2022-02-01T09:33:57Z

src/qt/trafficgraphwidget.cpp

@@ -135,32 +161,35 @@ void TrafficGraphWidget::updateRates()
    nLastBytesIn = bytesIn;
    nLastBytesOut = bytesOut;

-    while(vSamplesIn.size() > DESIRED_SAMPLES) {
+    while(vSamplesIn.size()  > FLT_MAX - 1) {


how much memory does this need?

concept ACK implementation NACK - it's unnecessary to store so many sample points, given the granulatory can be decreased as the times period gets longer. Resampling as the data gets older is a better way (as it avoids wasting memory on data that will never be displayed).

I agree - I have been thinking about how to do this. Maybe pruning the list at larger intervals - keeping samples that are above a moving average. Open to suggestions on implementation. :)

Thanks for looking at this!

We can chunk the end of the list at DESIRED_SAMPLES intervals - calculate the moving average - pruning samples that fall below it.

…ins)

The debugwindow - network graph hides ui elements btnClearTrafficGraph, lblGraphRange, sldGraphRange when at minimumHeight, it also hides the groupBox at minimumWidth - this maximizes the dimensions of the traffic graph in these small dimensions.

RandyMcMillan · 2022-02-02T21:32:41Z

rebase to fix Centos CI issue
874b2d8 - add hide panel logic which collapses window to a "desktop widget"
bb5b4cc - changed DESIRED_SAMPLES to 300 - reducing overall memory usage - going to try some other ideas to minimize memory usage. (interim adjustment based on @rebroad's comment)
c0f46d2 - the linear scale is the default presentation - this is familiar to users - a follow up PR should include a note on adding double click log scale to release notes.

commit 874b2d8 screen cast:

20220202160130623_trimmed.mp4

DrahtBot · 2022-02-04T11:02:44Z

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}

rebroad · 2022-02-07T19:47:19Z

I've been working on this, and I have a pull request almost ready to make - storing 600 samples per time range, and 14 ranges in total (from 5 minutes to 28 days), so 8400 samples in total.

video_2022-02-08_13-12-48.mp4

Or, smoother scaling of the horizontal also, or too gimicky? (below)

video_2022-02-16_22-05-15.mp4

The plan is to add notches on the slider for these main samples, but then allow the slider to stop in a few places in between, e.g. for 15m, 45m or 1h30m, 4h30m, 2days, etc.. the resolution will be slightly lower (as it's not sampled at these ranges), but it's probably nice to have these extra options.

RandyMcMillan · 2022-02-07T20:07:23Z

@rebroad - awesome!

RandyMcMillan · 2022-04-04T03:52:39Z

@rebroad - I am curious if your memory managment is ready...

I am happy to merge it into this PR...

hebasto · 2022-07-19T13:19:30Z

What is the status of this PR?

DrahtBot · 2022-10-31T10:30:31Z

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
Is it no longer relevant? ➡️ Please close.
Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

rebroad · 2022-12-10T20:57:12Z

What is the status of this PR?

I'm currently rebasing it. Should update soon.

DrahtBot · 2023-03-10T01:02:02Z

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
Is it no longer relevant? ➡️ Please close.
Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

hebasto · 2023-03-10T11:36:37Z

How do I label it as up for grabs?

Done.

RandyMcMillan mentioned this pull request Jan 27, 2022

Don't clear traffic graph when changing interval #484

Closed

This was referenced Jan 27, 2022

Replace int with std::chrono in for the timer->setInterval() argument #524

Merged

Show ToolTip on Network Traffic graph #492

Closed

Enable a non-linear network traffic option (click to toggle between linear and non-linear) #473

Closed

RandyMcMillan force-pushed the 1643263956-network-graph-issue-532 branch from 86120e9 to fba8ef0 Compare January 28, 2022 14:08

rebroad reviewed Feb 1, 2022

View reviewed changes

rebroad and others added 11 commits February 2, 2022 03:39

gui: network graph - remove uneccesary clear() when changing interval

9c9ea44

gui: network graph - scale view based on time interval

0fc40e3

gui: network graph - retain enough samples for large time intervals

55bae83

gui: network graph - fix left margin to hide paths

1d8a548

gui: network graph - use samples subset to determine tmax

aaf1bc3

qt:refactor: Use std::chrono in TrafficGraphWidget class

85b6adb

gui: network graph - add log-scale toggle

c7ac1b8

gui: network graph - add log-scale toggle on double click

f0871d1

gui: network graph - clean up colors - look better in log scale

9094941

gui: network graph - set initial QSlider value to first position (5 m…

255774f

…ins)

gui: netowrk graph - reduce DESIRED_SAMPLES to 300

bb5b4cc

RandyMcMillan added 2 commits February 2, 2022 03:39

gui: netowrk graph - linear scale default

c0f46d2

RandyMcMillan force-pushed the 1643263956-network-graph-issue-532 branch from 0902db8 to 874b2d8 Compare February 2, 2022 21:05

RandyMcMillan mentioned this pull request Feb 2, 2022

network graph - show/hide panels based on window width/height #540

Closed

DrahtBot added the Needs rebase label Feb 4, 2022

hebasto added the UX All about "how to get things done" label Feb 9, 2022

hebasto changed the title ~~gui: scale network graph based on time interval~~ Scale network graph based on time interval Feb 9, 2022

RandyMcMillan marked this pull request as draft February 17, 2022 15:10

rebroad mentioned this pull request Feb 24, 2022

Network graph improvements #559

Closed

hebasto added the Up for grabs label Mar 10, 2023

fanquake closed this Mar 10, 2023

bitcoin-core locked and limited conversation to collaborators Mar 9, 2024

Scale network graph based on time interval #539

Scale network graph based on time interval #539

Uh oh!

Conversation

RandyMcMillan commented Jan 27, 2022

Uh oh!

RandyMcMillan commented Jan 27, 2022

Uh oh!

RandyMcMillan commented Jan 27, 2022

Uh oh!

RandyMcMillan commented Jan 27, 2022

Uh oh!

DrahtBot commented Jan 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews

Conflicts

Uh oh!

RandyMcMillan commented Jan 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RandyMcMillan commented Jan 28, 2022

Uh oh!

rsafier commented Jan 29, 2022

Uh oh!

jonatack commented Jan 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RandyMcMillan commented Jan 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RandyMcMillan commented Jan 29, 2022

Uh oh!

RandyMcMillan commented Jan 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

w0xlt commented Jan 30, 2022

Uh oh!

rebroad Feb 1, 2022

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan Feb 1, 2022

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan Feb 1, 2022

Choose a reason for hiding this comment

Uh oh!

rebroad Feb 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan Feb 1, 2022

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan Feb 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan commented Feb 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Feb 4, 2022

Uh oh!

rebroad commented Feb 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RandyMcMillan commented Feb 7, 2022

Uh oh!

RandyMcMillan commented Apr 4, 2022

Uh oh!

hebasto commented Jul 19, 2022

Uh oh!

DrahtBot commented Oct 31, 2022

Uh oh!

rebroad commented Dec 10, 2022

Uh oh!

DrahtBot commented Mar 10, 2023

Uh oh!

hebasto commented Mar 10, 2023

Uh oh!

Uh oh!

DrahtBot commented Jan 27, 2022 •

edited

Loading

RandyMcMillan commented Jan 28, 2022 •

edited

Loading

jonatack commented Jan 29, 2022 •

edited

Loading

RandyMcMillan commented Jan 29, 2022 •

edited

Loading

RandyMcMillan commented Jan 29, 2022 •

edited

Loading

rebroad Feb 1, 2022 •

edited

Loading

RandyMcMillan Feb 1, 2022 •

edited

Loading

RandyMcMillan commented Feb 2, 2022 •

edited

Loading

rebroad commented Feb 7, 2022 •

edited

Loading