Make network graph slider easier to use #483
Conversation
There was a problem hiding this comment.
I like the idea of reducing the number of options and removing the redundant ones. I also think these 12 options are sufficient for any general user’s need.
I was able to test this PR successfully on Ubuntu 20.04. Here’s the screenshot of the Network Traffic window taken of the PR branch (slider at 20 minutes).
|
Concept NAK, 12 sliders are too few positions for such a large slider. I booted it and tested the 12 sliders. It feels like few positions. |
There was a problem hiding this comment.
I think this is fine to do, but I'm concept 0 on this.
Currently the network graph slider has 288 possible positions, and most of these are likely never used, due to obscure durations.
I think this is true.
This pull request simplifies the slider to have only 12 positions, making it much easier to use
How exactly does this make the slider "easier to use"? The workflow of using the slider as a slider remains untouched
@katesalazar This is intentional as there is talk about adding an extra button, and so the slider will be reduced in size in the future, but I do agree with you as it is. What extra durations do you propose being added? I propose 1-10 in steps of 1, 10-60 in steps of 5, 1hr to 2hr in steps of 0.5hrs, 2hr to 6hr in steps of 1hr, 6hrs to 24hrs in steps of 3hrs. That's a total of 10+10+2+4+3 = 29 steps. or 1,2,3,5,10,15,20,30,1h,2h,3h,6h,12h,18h,24h ? I really question whether people want 6,7,8,9,25,35,45,50,55,1.5h,4h,5h,9h,15h,21h... these seem unlikely to be used. |
@jarolrod because it is faster to use, i.e. less moving left and right to get the exact duration desired (usually a round number). |
|
nice, looking forward to the button
…On Tue, Dec 7, 2021 at 12:49 PM Rebroad ***@***.***> wrote:
Concept NAK, 12 sliders are too few positions for such a large slider.
I booted it and tested the 12 sliders. It feels like few positions. Please
iterate.
This is intentional as there is talk about adding an extra button, and so
the slider will be reduced in size in the future, but I do agree with you
as it is.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#483 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMRS4W674BMU6YHNH2MBLSDUPXYGDANCNFSM5IYHJOAQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. ConflictsNo conflicts as of last run. |
|
There hasn't been much activity lately. What is the status here? Finding reviewers may take time. However, if the patch is no longer relevant, please close this pull request. If the author lost interest or time to work on this, please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future. |
Closing due to lack of interest. |
Currently the network graph slider has 288 possible positions, and most of these are likely never used, due to obscure durations.
This pull request simplifies the slider to have only 12 positions, making it much easier to use, and setting the durations to more likely-wanted settings: 1m, 2m, 5m, 10m, 20m, 30m, 1h, 2h, 3h, 6h, 12h, 24h.
This change also allows easier rearranging of the window, for example, adding an extra button next to the reset button, shrinking the slider, and therefore making it still easy to use when smaller in length.