Enable a non-linear network traffic option (click to toggle between linear and non-linear) #473
Conversation
|
Love the idea, the problem with these things is When I do things like this, I always maintain the old behavior somehow, |
|
Concept ACK, this seems like a good idea to me, given that, what you really want to see in graphs like this is the gross magnitude and not so much very small variations in the throughput. |
b792418 to
b7483dd
Compare
I agree, which is why I've now (latest commit) made it toggleable - just click on the graph to switch between the two display options. |
|
Concept ACK.
Obscure, but OK. |
6f741d3 to
fe34ec3
Compare
| path.lineTo(x, y); | ||
| } | ||
| path.lineTo(x, YMARGIN + h); | ||
| } | ||
| } | ||
|
|
||
| void TrafficGraphWidget::mousePressEvent(QMouseEvent *event) |
There was a problem hiding this comment.
This isn't a great UI decision for end users. This functionality is hidden from users. If they discover it, it would be by accident; after having clicked on the Network Traffic widget.
Let's make this feature more accessible and documented by adding two buttons next to the reset button: one that sets the existing format and another button that enables the new format introduced in this PR.
The fToggle variable here should then be made into a persistent setting.
Additionally, when a longer sampling period has been set with the slider; it can take a minute or longer for the format to switch. There are optimizations that need to be done. I have not investigated this.
There was a problem hiding this comment.
@jarolrod What options are available so far for making GUI changes persistent? Regarding the delay when the slider is moved, I fixed that in a later update, and the delay now is no longer than the delay already present when clicking the reset button.
What more obvious way might there be to reveal the Y axis is toggleable? A tooltip on the graph perhaps? I am reluctant to add extra buttons given the slider is already providing many values in so little space, so I do prefer the clicking on the graph to change it. It may be that someone finds it by accident, but then this could be a pleasant surprise that - an "easter egg" feature!
There was a problem hiding this comment.
What more obvious way might there be to reveal the Y axis is toggle-able?
Yes, button, of course! Checkbox, radio, all those are good.
A tooltip on the graph perhaps?
Improves from no tooltip, but no,
that's not enough improvement.
I am reluctant to add extra buttons given the slider is already providing many values in so little space, so I do prefer the clicking on the graph to change it.
What? No, that's an huge slider. An unnecessarily large one.
Sliders can be as small as necessary when they are
combined with a text-box presenting the slided value.
There's a huge empty space below the legend too.
There's plenty of available space to discard invisible toggles.
It may be that someone finds it by accident, but then this could be a pleasant surprise that - an "easter egg" feature!
No, an easter egg is meant to be fun or charming in
some way. Hiding actual feature in the same way like
one could do with a true easter egg transgredes
the principle of least surprise.
Cheers!
There was a problem hiding this comment.
@jarolrod The latest commit makes the update immediate now (using QWidget::update).
fe34ec3 to
72cf1ce
Compare
|
Concept ACK. |
72cf1ce to
f18e40c
Compare
|
Concept ACK More useful information "at a glance". |
|
Adding a label to the highest horizontal line would be useful. |
f18e40c to
26117b7
Compare
I did consider this, but as it's not the current functionality, and it would make the highest point on the graph no longer reach the top (as the label would need extra space) I decided against it. Could be done as a separate pull request though. |
26117b7 to
8388b90
Compare
@RandyMcMillan #492 also reduces the need for this as now you can point to a point on the graph to get details. e.g. |
8388b90 to
ff4f33e
Compare
ff4f33e to
ad431ff
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
|
@rebroad - added this in PR #539 NOTE: I was careful to preserve commit authorship attribution: 👍🏽 |
|
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened. |
Helps to make visible the low bandwidth traffic and high bandwidth (or spikes) concurrently. (Previously the low bandwidth traffic becomes invisible in the presence of spikes).
Old format:
New format:
Old format:
New format:
(clicking on the graph will toggle between the new format and the old format).