Sync to upstream #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix Windows CI build. The Windows SDK versions present on our CI options (GitHub Actions hosted runners, AppVeyor) have headers that cause compilation warnings when included with MSVC operating in modern C modes (C11+). This PR disables the compilation warning caused by the Windows SDK headers, so we can get Windows feedback from CI. The warnings can be re-enabled when the Windows SDK used by our CI is upgraded to a version that doesn't trigger warnings. * Switch CI to GitHub Actions.
The Windows SDK versions present on our CI options (GitHub Actions hosted runners, AppVeyor) have headers that cause compilation warnings when included with MSVC operating in modern C modes (C11+). This PR disables the compilation warning caused by the Windows SDK headers, so we can get Windows feedback from CI. The warnings can be re-enabled when the Windows SDK used by our CI is upgraded to a version that doesn't trigger warnings.
willcl-ark
reviewed
Aug 28, 2024
There was a problem hiding this comment.
The CI + CMakeLists.txt as they stand here are not worth adding: https://github.com/willcl-ark/crc32c-subtree/actions/runs/10605521278/job/29394471127
But tests and benches can be relatively easily hacked(1) out(2) to get an array of simple build tests passing again: https://github.com/willcl-ark/crc32c-subtree/actions/runs/10605602819
(I assume this is preferable to merging 3rd party deps).
The rest is trivial enough.
| @@ -1,7 +1,6 @@ | |||
| # CRC32C | |||
|
|
|||
| [](https://travis-ci.org/google/crc32c) | |||
| [](https://ci.appveyor.com/project/pwnall/crc32c) | |||
| [](https://github.com/google/crc32c/actions/workflows/build.yml) | |||
There was a problem hiding this comment.
This isn't correct for us, but can be fixed later
|
The point is just to pull the upstream changes. Any other (relevant) changes could be done in a followup. |
|
Yes I agree, in this case it looks fine to me. 👍🏼 Ripping out the third party stuff from the CMakLists and CI is easy enough to do later. |
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Aug 7, 2025
efb8ea04e4 Merge bitcoin-core/crc32c-subtree#8: Sync to upstream 4a7a05c48d Merge remote-tracking branch 'google/main' into bitcoin-fork 21fc8ef304 Fix typo (bitcoin#59) 89f69843a1 Fix misspelled "Proccess" in comment 02e65f4fd3 Bump deps (bitcoin#56) b9d6e825a1 Fix Windows CI build. (bitcoin#54) bbbb93ab5d Switch CI to GitHub Actions (bitcoin#55) d46cd17d70 Add clangd cache directory to .gitignore. git-subtree-dir: src/crc32c git-subtree-split: efb8ea04e4a5b6a18dc4bc1908fd1cb2dcefb585
fanquake
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Aug 7, 2025
9a5d297 Squashed 'src/crc32c/' changes from b60d2b7334..efb8ea04e4 (fanquake) Pull request description: Sync the subtree with latest upstream. The changes here are a no-op, but pull them to fix the drive-by-typo-fixing: #33057. Includes bitcoin-core/crc32c-subtree#8. ACKs for top commit: maflcko: lgtm ACK 8ef8dd6 janb84: ACK 8ef8dd6 Tree-SHA512: b20a47514218206b934c4aa27ec667fb9b3ec7f7388a78725c52fc6e916358d2b9a2075a37808dbc2430b4c7816511ecf20e36bfe2fbd2d8a26bc8882a46d5e7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls the few changes from upstream (last commit ~ 2 years ago).
Seems reasonable to do before making any other changes. i.e #7, or if we are going to make further changes to the CMake build system etc.