Bitcoin Core 29.0 #1119
Merged
Bitcoin Core 29.0 #1119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glozow
commented
Apr 7, 2025
73b2e1c to
c053a4c
Compare
darosior
reviewed
Apr 8, 2025
darosior
reviewed
Apr 8, 2025
|
CI is failing, probably want that to be green before merging, otherwise this won't deploy properly. |
fanquake
reviewed
Apr 14, 2025
b6780de to
ab41102
Compare
glozow
commented
Apr 14, 2025
|
|
||
| ### Tools and Utilities | ||
|
|
||
| - A new tool [`utxo_to_sqlite.py`](https://github.com/bitcoin/bitcoin/blob/v29.0/contrib/utxo-tools/utxo_to_sqlite.py) |
There was a problem hiding this comment.
This was the build error so I changed the link.
Edit: Diff can be checked with git diff ../bitcoin/doc/release-notes.md _releases/29.0.md
1 task
|
Bins are up, added magnet link. Ready for review. |
mzumsande
reviewed
Apr 14, 2025
|
ACK 5c45a40 |
darosior
reviewed
Apr 14, 2025
Comment on lines
+126
to
+130
| miners will not accidentally violate the timewarp rule. (#31376, #31600) | ||
| As a reminder, it's important that any software which uses the `getblocktemplate` | ||
| RPC takes these values into account (either `curtime` or `mintime` is fine). | ||
| Relying only on a clock can lead to invalid blocks under some circumstances, | ||
| especially once a timewarp fix is deployed. (#31600) |
There was a problem hiding this comment.
I think it renders the same, so just kept the indentation as is.
_releases/29.0.md
Outdated
Comment on lines
136
to
138
| `scanblocks` to lessen the need for additional indexing programs. (#30708) | ||
|
|
||
|
|
_releases/29.0.md
Outdated
Comment on lines
19
to
20
| ## Link should be enclosed in quotes and start with: "magnet:? | ||
| optional_magnetlink: magnet:?xt=urn:btih:c2ebe360dc7e85d9850196ea57712c8ddffbcd59&dn=bitcoin-core-29.0&tr=udp%3A%2F%2Ftracker.openbittorrent.com%3A80&tr=udp%3A%2F%2Ftracker.opentrackr.org%3A1337%2Fannounce&tr=udp%3A%2F%2Ftracker.coppersurfer.tk%3A6969%2Fannounce&tr=udp%3A%2F%2Ftracker.leechers-paradise.org%3A6969%2Fannounce&tr=udp%3A%2F%2Fexplodie.org%3A6969%2Fannounce&tr=udp%3A%2F%2Ftracker.torrent.eu.org%3A451%2Fannounce&tr=udp%3A%2F%2Ftracker.bitcoin.sprovoost.nl%3A6969&ws=http%3A%2F%2Fbitcoincore.org%2Fbin%2F |
There was a problem hiding this comment.
Comment states link should be in quotes?
Suggested change
| ## Link should be enclosed in quotes and start with: "magnet:? | |
| optional_magnetlink: magnet:?xt=urn:btih:c2ebe360dc7e85d9850196ea57712c8ddffbcd59&dn=bitcoin-core-29.0&tr=udp%3A%2F%2Ftracker.openbittorrent.com%3A80&tr=udp%3A%2F%2Ftracker.opentrackr.org%3A1337%2Fannounce&tr=udp%3A%2F%2Ftracker.coppersurfer.tk%3A6969%2Fannounce&tr=udp%3A%2F%2Ftracker.leechers-paradise.org%3A6969%2Fannounce&tr=udp%3A%2F%2Fexplodie.org%3A6969%2Fannounce&tr=udp%3A%2F%2Ftracker.torrent.eu.org%3A451%2Fannounce&tr=udp%3A%2F%2Ftracker.bitcoin.sprovoost.nl%3A6969&ws=http%3A%2F%2Fbitcoincore.org%2Fbin%2F | |
| ## Link should be enclosed in quotes and start with: "magnet:? | |
| optional_magnetlink: "magnet:?xt=urn:btih:c2ebe360dc7e85d9850196ea57712c8ddffbcd59&dn=bitcoin-core-29.0&tr=udp%3A%2F%2Ftracker.openbittorrent.com%3A80&tr=udp%3A%2F%2Ftracker.opentrackr.org%3A1337%2Fannounce&tr=udp%3A%2F%2Ftracker.coppersurfer.tk%3A6969%2Fannounce&tr=udp%3A%2F%2Ftracker.leechers-paradise.org%3A6969%2Fannounce&tr=udp%3A%2F%2Fexplodie.org%3A6969%2Fannounce&tr=udp%3A%2F%2Ftracker.torrent.eu.org%3A451%2Fannounce&tr=udp%3A%2F%2Ftracker.bitcoin.sprovoost.nl%3A6969&ws=http%3A%2F%2Fbitcoincore.org%2Fbin%2F" |
Comment on lines
+26
to
+27
| disclosed. Additionally, low severity vulnerabilities affecting versions 28.x | ||
| (if any) will be disclosed. |
There was a problem hiding this comment.
Should we say "in 2 weeks" or even give a specific date if you expect to publish today?
There was a problem hiding this comment.
Let's say 2 weeks. Sometimes we miss intended deadlines when we don't have people to review stuff.
|
ACK ddc2041 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.