update-translations: Perform git and build system updates #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK |
Add code to perform the steps from the build process to update git, the qt resource file, and the build system automatically.
d3081e8 to
1f22990
Compare
laanwj
commented
Sep 28, 2019
update-translations.py
Outdated
| # update Makefile | ||
| with open('src/Makefile.qt.include', 'r') as f: | ||
| lines = list(f) | ||
| with open('src/Makefile.qt.include', 'w') as f: |
There was a problem hiding this comment.
This part would be much simpler if the file with locale definitions was a separate include file, which could be fully generated instead of editing an existing file. This works right now, though.
There was a problem hiding this comment.
Did this in a new commit. I retain the old code in the older commit for older versions, though it'd likely be better to backport bitcoin/bitcoin#16982 to all releases that we care about.
laanwj
added a commit
to laanwj/bitcoin
that referenced
this pull request
Sep 29, 2019
Move qt translations to a separate make include file. This makes it easier to auto-generate this list from tooling (see bitcoin-core/bitcoin-maintainer-tools#36).
laanwj
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Sep 30, 2019
4320bfc build: Factor out qt translations from build system (Wladimir J. van der Laan) Pull request description: Move qt translations to a separate make include file. This makes it easier to auto-generate this list from tooling (see bitcoin-core/bitcoin-maintainer-tools#36). ACKs for top commit: promag: ACK 4320bfc. Tree-SHA512: 7133d0103bcf97672ae5aa40ba35d4b81331a8c179190031bbc887da6a5ccc929428e522938db43d87dbcbf9ad3b121dac1e6faf1daa5ae81d0b5fed7f053b5f
laanwj
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Sep 30, 2019
e2ce392 test: Avoid whitespace linting in qt translations (Wladimir J. van der Laan) 977dd23 qt: Periodic translations update (Wladimir J. van der Laan) Pull request description: Pull new translations from Transifex (using bitcoin-core/bitcoin-maintainer-tools#36) and run `make translate`. (maybe the last one before the split-off) Also added a commit to add `src/qt/locale` to the exclusions for the whitespace linter. I don't think automatically generated files should be linted. Top commit has no ACKs. Tree-SHA512: 53aee46d44eceb18f78034febe76ac4d346c643dfc5a16878193433f85db1642977a7028bb2cf99c2c10d972d833c742f7f873991691b5d9f81b2df7b2679bf9
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Oct 1, 2019
Move qt translations to a separate make include file. This makes it easier to auto-generate this list from tooling (see bitcoin-core/bitcoin-maintainer-tools#36). Github-Pull: bitcoin#16982 Rebased-From: 4320bfc
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 2, 2019
Move qt translations to a separate make include file. This makes it easier to auto-generate this list from tooling (see bitcoin-core/bitcoin-maintainer-tools#36).
|
I'm going to merge this as this is what I'm using for updates on 0.19, it seems to work well enough. |
laanwj
added a commit
that referenced
this pull request
Oct 4, 2019
7013110 update-translations: Simplify makefile update after factoring out qt locale include (Wladimir J. van der Laan) 1f22990 update-translations: Perform git and build system updates (Wladimir J. van der Laan) Pull request description: Add code to perform the steps from the build process to update git, the qt resource file, and the build system automatically. Top commit has no ACKs. Tree-SHA512: 6b1f46ce50588795afbc3a29432cc4cc63b2f9ef83baf16321126859603c3083703670ef15989896f3df60db7071abd4732cdf66579c3df6a93aadcac2d3e999
barrystyle
pushed a commit
to zentoshi/zentoshi
that referenced
this pull request
Nov 11, 2019
Move qt translations to a separate make include file. This makes it easier to auto-generate this list from tooling (see bitcoin-core/bitcoin-maintainer-tools#36).
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Nov 17, 2019
Move qt translations to a separate make include file. This makes it easier to auto-generate this list from tooling (see bitcoin-core/bitcoin-maintainer-tools#36).
blocknetdx-builds
pushed a commit
to blocknetdx/blocknet
that referenced
this pull request
Sep 22, 2020
Move qt translations to a separate make include file. This makes it easier to auto-generate this list from tooling (see bitcoin-core/bitcoin-maintainer-tools#36). Github-Pull: #16982 Rebased-From: 4320bfc0c0d88633c84146f8d640f5b6e4596244
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Dec 9, 2021
4320bfc build: Factor out qt translations from build system (Wladimir J. van der Laan) Pull request description: Move qt translations to a separate make include file. This makes it easier to auto-generate this list from tooling (see bitcoin-core/bitcoin-maintainer-tools#36). ACKs for top commit: promag: ACK 4320bfc. Tree-SHA512: 7133d0103bcf97672ae5aa40ba35d4b81331a8c179190031bbc887da6a5ccc929428e522938db43d87dbcbf9ad3b121dac1e6faf1daa5ae81d0b5fed7f053b5f
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Dec 23, 2021
4320bfc build: Factor out qt translations from build system (Wladimir J. van der Laan) Pull request description: Move qt translations to a separate make include file. This makes it easier to auto-generate this list from tooling (see bitcoin-core/bitcoin-maintainer-tools#36). ACKs for top commit: promag: ACK 4320bfc. Tree-SHA512: 7133d0103bcf97672ae5aa40ba35d4b81331a8c179190031bbc887da6a5ccc929428e522938db43d87dbcbf9ad3b121dac1e6faf1daa5ae81d0b5fed7f053b5f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add code to perform the steps from the build process to update git, the qt resource file, and the build system automatically.